set fsevent-sys crate minor version #315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears #313 would also be a viable fix to this, however this would be a simpler change as of now. |
|
Yeah apparently octplane/fsevent-rust#32 didn't change things according to semver. |
|
Closing this in favor of: octplane/fsevent-rust#38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #314
fsevent-sysrecently released version "3.2", however this had a breaking change changing two parameters of theircallbackfunction from two*mut c_voidto au32andu64pointer.Setting the version major & minor will help prevent breaking changes released in minor versions.
Note:
Another alternative is to update to "3.2" and fix the API accordingly, however this PR was the simplest.