Wasm_of_ocaml with alternative dune support #1726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/WebAssembly/js-string-builtins Enabled with flag --experimental-wasm-imported-strings in node, and through chrome://flags/#enable-experimental-webassembly-features in Chrome.
Implement mapping between source and wasm locations. To work, this requires a version of Binaryen compiled with Jérôme's patch WebAssembly/binaryen#6372. Single-stepping can jump around in slightly surprising ways in the OCaml code, due to the different order of operations in wasm. This could be improved by modifying Binaryen to support “no location” annotations. Another future improvement can be to support mapping Wasm identifiers to OCaml ones. Co-authored-by: Jérôme Vouillon <[email protected]>
Sourcemap support for wasm
Tuple syntax changes
We were just numbering them. This should make the output more readable since we are propagating names from the OCaml source code.
Directly use the name from the OCaml code if possible, with a suffix in case of ambiguity. Use short names for not explictly named variables.
Use Js string builtins when available
- more options - do not keep temp files - use a relative path as a sourcemap url
Minify runtime
Improve Wat output
Partial application fix
Separate compilation
Get latest changes from js_of_ocaml
Fix creation of float arrays
When the size of a piece of code changes, report that its end position changes, rather than its start position.
- Wasm AST: use a standalone event instruction to indicate code locations - Add location at end of functions - Hide code with no location
Source map improvements
So that we test whole-program compilation a bit.
hhugo
reviewed
Nov 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ocaml/dune#11093 (comment)