Merge wasm_of_ocaml #1724

OlivierNicole · 2024-10-31T10:21:36Z

This aims to merge wasm_of_ocaml, currently hosted at https://github.com/ocaml-wasm/wasm_of_ocaml, back into this repo.

~~This is pending on Dune support ocaml/dune#11029. For now, Dune is pinned for the CI jobs.~~

* Support for dialogElement * Added cancel and close events --------- Co-authored-by: Hugo Heuzard <[email protected]>

* Compiler: fix free variable for classes

…ith OCaml libraries Use: js_of_ocaml --toplevel --no-runtime runtime.js library.cma

Integrate "added 'ellipse' method to canvasRenderingContext2D" (ocsigen#1555)

runtime/wasm/runtime.js

Runtime: remove some unimplemented primitives

This reverts commit f428e0e.

hhugo · 2024-12-04T20:25:49Z

Thanks for all the hard work

dbuenzli · 2024-12-04T20:36:45Z

Bravo! Is there some high level docs on how to use the stuff ?

vouillon · 2024-12-04T21:07:10Z

Bravo! Is there some high level docs on how to use the stuff ?

There is a short README_wasm_of_ocaml.md. But I still need to write some documentation...

rickyvetter · 2024-12-04T21:59:56Z

Incredible! This is awesome.

dbuenzli · 2024-12-04T22:00:36Z

There is a short README_wasm_of_ocaml.md.

This looks to good to be true :–) The browsers APIs can be used as is ?

However it is possible to make it work over the file:// protocol ? And what's the story with webworkers ?

I have a number crunching app (computing thousands of polygon intersections) that I distribute as a single double-clickable .html file. It would be interesting to see the gains there. However it uses extremely dirty tricks to make webworkers work out of a single js_of_ocaml compiled file with code paths differentiated in the main via Worker.ami.

vouillon · 2024-12-04T23:29:48Z

The browsers APIs can be used as is ?

Right.

However it is possible to make it work over the file:// protocol ?

Not at the moment. Source Phase Imports might make it possible at some point. Or maybe we could have an option to somehow embed the Wasm code in the JavaScript code.

And what's the story with webworkers ?

I'm not sure. What problem could there be?

I have a number crunching app (computing thousands of polygon intersections) that I distribute as a single double-clickable .html file. It would be interesting to see the gains there. However it uses extremely dirty tricks to make webworkers work out of a single js_of_ocaml compiled file with code paths differentiated in the main via Worker.ami.

This might just work if we embed the Wasm code.

dbuenzli · 2024-12-04T23:55:31Z

I'm not sure. What problem could there be?

I'm concerned about data transfers. With webworkers you are supposed to transfer JavaScript values that that go through the structured clone algorithm.

As we once discussed that worked relatively flawlessly with js_of_ocaml's encoding of OCaml values encoded as JavaScript values.

Now I don't know how OCaml values are represented in wasm_of_ocaml, but in the webworker work queue I linked to I'm basically using Obj.magic on OCaml values to transfer work items but if those are no longer represented as JavaScript values then I expect kaboom.

vouillon · 2024-12-05T09:15:25Z

OCaml values are represented using Wasm GC values, so indeed the structured clone algorithm will not work on them. You have to serialize them somehow. You can try Marshal which works much better than with Js_of_ocaml (integers and floats do not share the same representation).

I have some experimental code to embed the Wasm code within the JavaScript code. Maybe you could give it a try.

micahcantor · 2024-12-05T16:01:32Z

Congrats @vouillon @OlivierNicole @hhugo 🎉 !

The attempts to update the workflow as Wasm_of_ocaml has been merged upstream in ocsigen/js_of_ocaml#1724 and the wasm-dune branch is gone. Signed-off-by: Marek Kubica <[email protected]>

The attempts to update the workflow as Wasm_of_ocaml has been merged upstream in ocsigen/js_of_ocaml#1724 and the wasm-dune branch is gone. Signed-off-by: Marek Kubica <[email protected]> Signed-off-by: Chris Armstrong <[email protected]>

CHANGES: ## Features/Changes * Compiler/Runtime: Make resuming a continuation more efficient in js (ocsigen/js_of_ocaml#1765) * Compiler/Runtime: Effects: add an optional feature of "dynamic switching" between CPS and direct style, resulting in better performance when no effect handler is installed * Compiler: Merged Wasm_of_ocaml (ocsigen/js_of_ocaml#1724) * Lib: fix the type of some DOM properties and methods (ocsigen/js_of_ocaml#1747) * Lib: removed no longer relevant Js.optdef type annotations (ocsigen/js_of_ocaml#1769) * Lib: Add other textMetrics property (ocsigen/js_of_ocaml#1784) * Lib: rename Firebug to Console (ocsigen/js_of_ocaml#1802) * Test: use dune test stanzas (ocsigen/js_of_ocaml#1631) * Test: run wasm tests on windows * Misc: drop support for IE * Misc: move tests to OCaml 5.3 * Misc: import many test from the OCaml codebase * Runtime: support for float16 bigarrays * Runtime: support more Unix functions (ocsigen/js_of_ocaml#1823) * Runtime: various filesystem fixes (ocsigen/js_of_ocaml#1825) ## Bug fixes * Compiler: Fix small bug in global data flow analysis (ocsigen/js_of_ocaml#1768) * Runtime: no longer leak channels * Runtime: Fix Marshal.to_buffer (ocsigen/js_of_ocaml#1798) * Runtime: unmarshalling objects should refresh its id * Runtime: check size upper bound during array creation * Runtime: return sys_error when reading from a closed channels * Runtime: fix parsing of hex-float with very large exponent * Runtime: make sure [n / 0L] is not optimized away by DCE * Runtime: fix Unix.LargeFile.stat/lstat * Runtime: fix stat/lstat times * Runtime: fix reading from stdin in an interactive nodejs

vouillon and others added 30 commits September 3, 2024 16:43

Fix hyperbolic tree example

e30e540

Lib: Dialog element support (ocsigen#1257)

5a0a119

* Support for dialogElement * Added cancel and close events --------- Co-authored-by: Hugo Heuzard <[email protected]>

Lib: fix paragraph construction and coercion

4ce9356

Lib: Add Typed_array.Bytes module (ocsigen#1609)

e3f7aa1

Add download attribute to anchor element

de31b5a

Compiler: dedicated type for "special" values (ocsigen#1573)

6dc6697

Compiler: remove last argument of Pushtrap (ocsigen#1575)

c860567

Compiler: track block mutability (ocsigen#1603)

5db44d2

Compiler: lower level switch

e2c98ec

Compiler: fix free variable for classes (ocsigen#1524)

3146b32

* Compiler: fix free variable for classes

Compiler: minify labels

0ef5c70

Compiler: fix es6 scopes

6beaabe

Compiler: improve complexity in parser production

7977f85

Compiler: support for es6 import/export (ocsigen#1529)

2263216

Compiler: lazy cmdliner term

924ab20

Compiler: js-parser: fix class member printing

ad7a1c8

Compiler: js-parser: preserve consise body

df89877

Compiler: js-parser: fix assignment target

d2b703a

Compiler: Make it possible to link runtime JavaScript file together w…

ba117ee

…ith OCaml libraries Use: js_of_ocaml --toplevel --no-runtime runtime.js library.cma

Compiler: small refactoring

fa2742a

Compiler: refactoring

4f541b9

Compiler: remove deprecated cmdline runtime-only flag

3694f14

Compiler: refactoring

efbe91a

Compiler: new include-partial-runtime flag

0c71444

Tests: add test for compact option

b4be113

Compiler: use consise body in arrow when es6 is enabled

7eee7ed

Misc: disable some test on older ocaml

7721b16

Rename cps_calls into trampolined_calls for clarity

1c17c1e

Merge pull request ocsigen#65 from OlivierNicole/converge-jsoo-merge-02

56919bc

Integrate "added 'ellipse' method to canvasRenderingContext2D" (ocsigen#1555)

Misc: yojson is no longer optional

08316ce

hhugo and others added 2 commits December 4, 2024 14:18

Github action to setup binaryen

edb11fa

Flow.the_native_string_of: add comment

1e2c57d

hhugo reviewed Dec 4, 2024

View reviewed changes

runtime/wasm/runtime.js Outdated Show resolved Hide resolved

vouillon and others added 7 commits December 4, 2024 15:01

Runtime: implement Sys.is_directory

913dc6e

Remove unimplemented primitives

13f8c2f

Merge pull request ocsigen#138 from ocaml-wasm/unimplemented-primitives

889e292

Runtime: remove some unimplemented primitives

Revert "Github action: automatically merge with js_of_ocaml"

18ced4b

This reverts commit f428e0e.

Move READMEs

400e0d5

Changelog

e30da15

CI: no longer run the wasm workflow on all pushes

217cc8b

vouillon force-pushed the main branch from d8075db to 217cc8b Compare December 4, 2024 19:38

Merge branch 'master' into main

9cfbfc4

hhugo merged commit 9cfbfc4 into ocsigen:master Dec 4, 2024
27 checks passed

Leonidas-from-XIV mentioned this pull request Dec 5, 2024

Update Wasm_of_ocaml action ocaml/dune#11184

Merged

hhugo mentioned this pull request Feb 3, 2025

[WIP] [new release] js_of_ocaml (8 packages) (6.0.0) ocaml/opam-repository#27361

Closed

hhugo mentioned this pull request Feb 7, 2025

[new release] js_of_ocaml (8 packages) (6.0.1) ocaml/opam-repository#27402

Merged

stepbrobd mentioned this pull request Feb 21, 2025

ocamlPackages.wasm_of_ocaml-compiler: init at 6.0.1 NixOS/nixpkgs#384029

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge wasm_of_ocaml #1724

Merge wasm_of_ocaml #1724

OlivierNicole commented Oct 31, 2024 •

edited by hhugo

Loading

hhugo commented Dec 4, 2024

dbuenzli commented Dec 4, 2024

vouillon commented Dec 4, 2024

rickyvetter commented Dec 4, 2024

dbuenzli commented Dec 4, 2024

vouillon commented Dec 4, 2024

dbuenzli commented Dec 4, 2024 •

edited

Loading

vouillon commented Dec 5, 2024

micahcantor commented Dec 5, 2024

Merge wasm_of_ocaml #1724

Merge wasm_of_ocaml #1724

Conversation

OlivierNicole commented Oct 31, 2024 • edited by hhugo Loading

hhugo commented Dec 4, 2024

dbuenzli commented Dec 4, 2024

vouillon commented Dec 4, 2024

rickyvetter commented Dec 4, 2024

dbuenzli commented Dec 4, 2024

vouillon commented Dec 4, 2024

dbuenzli commented Dec 4, 2024 • edited Loading

vouillon commented Dec 5, 2024

micahcantor commented Dec 5, 2024

OlivierNicole commented Oct 31, 2024 •

edited by hhugo

Loading

dbuenzli commented Dec 4, 2024 •

edited

Loading