-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dune test stanza #1631
Use dune test stanza #1631
Conversation
887bb01
to
a1c0e4a
Compare
I'm guessing the relevant dune PR is ocaml/dune#10671, in which case this PR is blocked until dune 3.17 is released (https://github.com/ocaml/dune/milestone/58) |
xref ocaml/dune#11143 |
@vouillon, can you rebase this PR using the latest version of dune 3.17 ? I think they've drop the change that caused most dune file to be reformatted. |
I plan to merge this PR before merging #1724 |
@@ -6,6 +6,8 @@ | |||
(executable | |||
(name test) | |||
(modules test) | |||
(enabled_if | |||
(<> %{profile} using-effects)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this diff ?
CHANGES: ## Features/Changes * Compiler/Runtime: Make resuming a continuation more efficient in js (ocsigen/js_of_ocaml#1765) * Compiler/Runtime: Effects: add an optional feature of "dynamic switching" between CPS and direct style, resulting in better performance when no effect handler is installed * Compiler: Merged Wasm_of_ocaml (ocsigen/js_of_ocaml#1724) * Lib: fix the type of some DOM properties and methods (ocsigen/js_of_ocaml#1747) * Lib: removed no longer relevant Js.optdef type annotations (ocsigen/js_of_ocaml#1769) * Lib: Add other textMetrics property (ocsigen/js_of_ocaml#1784) * Lib: rename Firebug to Console (ocsigen/js_of_ocaml#1802) * Test: use dune test stanzas (ocsigen/js_of_ocaml#1631) * Test: run wasm tests on windows * Misc: drop support for IE * Misc: move tests to OCaml 5.3 * Misc: import many test from the OCaml codebase * Runtime: support for float16 bigarrays * Runtime: support more Unix functions (ocsigen/js_of_ocaml#1823) * Runtime: various filesystem fixes (ocsigen/js_of_ocaml#1825) ## Bug fixes * Compiler: Fix small bug in global data flow analysis (ocsigen/js_of_ocaml#1768) * Runtime: no longer leak channels * Runtime: Fix Marshal.to_buffer (ocsigen/js_of_ocaml#1798) * Runtime: unmarshalling objects should refresh its id * Runtime: check size upper bound during array creation * Runtime: return sys_error when reading from a closed channels * Runtime: fix parsing of hex-float with very large exponent * Runtime: make sure [n / 0L] is not optimized away by DCE * Runtime: fix Unix.LargeFile.stat/lstat * Runtime: fix stat/lstat times * Runtime: fix reading from stdin in an interactive nodejs
This requires some fixes in dune...