[new release] ocaml-lsp-server, lsp and jsonrpc (1.8.3) #19652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES: - Fix debouncing of document updates. It was essentially complicated broken in all but the most trivial cases. (ocaml/ocaml-lsp#509 fixes ocaml/ocaml-lsp#504) - Fix completion when passing named and functional arguments (ocaml/ocaml-lsp#512)
|
@mseri could you give this a review perhaps? |
|
I just re-triggered some CI jobs... |
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LSP Server for OCaml
CHANGES:
Fix debouncing of document updates. It was essentially complicated broken in
all but the most trivial cases. (Doc update performance ocaml-lsp#509 fixes Diagnostics are played back slowly if didChange events are coming in faster than diagnostics are produced ocaml-lsp#504)
Fix completion when passing named and functional arguments (Fix completion for symbols passed as named arg ocaml-lsp#512)