Fix completion for symbols passed as named arg #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
reviewed
Sep 22, 2021
ocaml-lsp-server/src/compl.ml
Outdated
| String.sub text ~pos ~len | ||
| let reconstructed_prefix = String.sub text ~pos ~len in | ||
| (* if we reconstructed [~f:ignore], we should take only [ignore], so: *) | ||
| if not (String.is_prefix reconstructed_prefix ~prefix:"~") then |
There was a problem hiding this comment.
Without looking at this very deeply, why doesn't the problem exist for optional arguments?
There was a problem hiding this comment.
Excellent remark. Fixed handling for optional args as well.
rgrinberg
approved these changes
Sep 25, 2021
ulugbekna
force-pushed
the
fix-compl-named-arg
branch
from
d096d80 to
bdee5e6
Compare
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Sep 27, 2021
CHANGES: - Fix debouncing of document updates. It was essentially complicated broken in all but the most trivial cases. (ocaml/ocaml-lsp#509 fixes ocaml/ocaml-lsp#504) - Fix completion when passing named and functional arguments (ocaml/ocaml-lsp#512)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prefix_of_positionis getting complicated; I hope we're not breaking anything with this fix