Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(lsp): add workspace/diagnostic/refresh #910

Merged

Conversation

rgrinberg
Copy link
Member

Signed-off-by: Rudi Grinberg [email protected]

ps-id: d3baaa27-3e39-4957-84fe-3d2552e72261

Signed-off-by: Rudi Grinberg <[email protected]>

ps-id: d3baaa27-3e39-4957-84fe-3d2552e72261
@rgrinberg rgrinberg merged commit 51e2ef0 into master Nov 5, 2022
rgrinberg added a commit to rgrinberg/opam-repository that referenced this pull request Nov 6, 2022
CHANGES:

## Fixes

- Fix random requests failing after switching documents (ocaml/ocaml-lsp#904, fixes ocaml/ocaml-lsp#898)

- Do not offer related diagnostic information unless the user enables in client
  capabilities (ocaml/ocaml-lsp#905)

- Do not offer diagnostic tags unless the client supports them (ocaml/ocaml-lsp#909)

- Do not attach extra data to diagnostics unless the client supports this
  (ocaml/ocaml-lsp#910)

- Use /bin/sh instead of /bin/bash. This fixes ocamllsp on NixOS
Khady added a commit to Khady/ocaml-lsp that referenced this pull request Nov 7, 2022
* master:
  chore(nix): update flakes (ocaml#915)
  chore(merlin): subrepo to submodule (ocaml#914)
  refactor: add signature_help mli (ocaml#913)
  fix: correctly use merlin's pipeline (ocaml#904)
  feature(lsp): add workspace/diagnostic/refresh (ocaml#910)
  refactor: add mli's to test helpers (ocaml#912)
  fix: client capabilities and diagnostics (ocaml#908)
  fix(lsp): respect diagnostic tag client capabilities (ocaml#909)
  refactor: related information in diagnostics (ocaml#907)
  test: update to show related information (ocaml#906)
  fix: offer related information only when supported (ocaml#905)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant