fix: correctly use merlin's pipeline #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulugbekna
requested changes
Nov 4, 2022
It should be fine b/c it creates the pipeline inside the merlin thread. |
rgrinberg
force-pushed
the
ps/rr/fix__correctly_use_merlin_s_pipeline
branch
from
74226d2 to
8680493
Compare
rgrinberg
force-pushed
the
ps/rr/fix__correctly_use_merlin_s_pipeline
branch
from
8680493 to
fa6b616
Compare
|
Shall we merge this? |
|
Let me try and fix the tests.
Rudi.
…On Nov 5, 2022, 10:54 AM -0600, Ulugbek Abdullaev ***@***.***>, wrote:
Shall we merge this?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
rgrinberg
force-pushed
the
ps/rr/fix__correctly_use_merlin_s_pipeline
branch
from
fa6b616 to
5be7e81
Compare
do not reuse pipelines unless we are using the same pipeline multiple times in a row Signed-off-by: Rudi Grinberg <[email protected]> ps-id: 383efc92-8d86-4d09-b01a-16fcf8c0a0d0
rgrinberg
force-pushed
the
ps/rr/fix__correctly_use_merlin_s_pipeline
branch
from
5be7e81 to
d1507c6
Compare
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Nov 6, 2022
CHANGES: ## Fixes - Fix random requests failing after switching documents (ocaml/ocaml-lsp#904, fixes ocaml/ocaml-lsp#898) - Do not offer related diagnostic information unless the user enables in client capabilities (ocaml/ocaml-lsp#905) - Do not offer diagnostic tags unless the client supports them (ocaml/ocaml-lsp#909) - Do not attach extra data to diagnostics unless the client supports this (ocaml/ocaml-lsp#910) - Use /bin/sh instead of /bin/bash. This fixes ocamllsp on NixOS
Khady
added a commit
to Khady/ocaml-lsp
that referenced
this pull request
Nov 7, 2022
* master: chore(nix): update flakes (ocaml#915) chore(merlin): subrepo to submodule (ocaml#914) refactor: add signature_help mli (ocaml#913) fix: correctly use merlin's pipeline (ocaml#904) feature(lsp): add workspace/diagnostic/refresh (ocaml#910) refactor: add mli's to test helpers (ocaml#912) fix: client capabilities and diagnostics (ocaml#908) fix(lsp): respect diagnostic tag client capabilities (ocaml#909) refactor: related information in diagnostics (ocaml#907) test: update to show related information (ocaml#906) fix: offer related information only when supported (ocaml#905)
This was referenced Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not reuse pipelines unless we are using the same pipeline multiple
times in a row
@ulugbekna let's get a quick fix in and work on optimizing in #901 parallel. This bug is likely very annoying to users.