fix(melange): unify public libraries (in-workspace vs external) #7163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
force-pushed
the
anmonteiro/installed-lib-path
branch
from
86885fa to
20fbd78
Compare
rgrinberg
reviewed
Feb 23, 2023
rgrinberg
approved these changes
Feb 23, 2023
anmonteiro
force-pushed
the
anmonteiro/installed-lib-path
branch
from
ba93c61 to
8a0f074
Compare
jchavarri
approved these changes
Feb 23, 2023
anmonteiro
force-pushed
the
anmonteiro/installed-lib-path
branch
from
8a0f074 to
36be563
Compare
Signed-off-by: Antonio Nuno Monteiro <[email protected]>
anmonteiro
force-pushed
the
anmonteiro/installed-lib-path
branch
from
36be563 to
4cdf598
Compare
rgrinberg
reviewed
Feb 23, 2023
| > grep -e "--bs-module-type" --after-context=1 | ||
| --bs-module-type | ||
| commonjs | ||
|
|
||
| Js rules should include --bs-package-name | ||
| $ dune rules $output/node_modules/pkg.app/my_project/app/b.js | | ||
| $ dune rules $output/node_modules/pkg.app/b.js | |
There was a problem hiding this comment.
Not related to this pr, but shouldn't this be pkg/app?
There was a problem hiding this comment.
It looks correct to me. the library name is pkg.app, we use that name for the node_modules folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--bs-package-outputargument for these libraries is now their relative path from the library root, rather than the path from the root of the project.