Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

melange: build stdlib, runtime and tests with dune #493

Merged
merged 53 commits into from
Mar 3, 2023
Merged

melange: build stdlib, runtime and tests with dune #493

merged 53 commits into from
Mar 3, 2023

Conversation

anmonteiro
Copy link
Member

@anmonteiro anmonteiro commented Feb 23, 2023 •
edited
Loading

This is the full version of the work started in #486.

Runtime tests are run:

  1. for the dune integration
  2. using the mel binary

depends on ocaml/dune#7163 and ocaml/dune#7153

@anmonteiro anmonteiro force-pushed the anmonteiro/port-tests-to-dune branch from 4c221fd to f7ec71a Compare February 23, 2023 07:11
@anmonteiro anmonteiro mentioned this pull request Feb 24, 2023
Merged
@anmonteiro anmonteiro force-pushed the anmonteiro/port-tests-to-dune branch from 7bd2b36 to cfd8f9b Compare February 24, 2023 22:43
@anmonteiro anmonteiro mentioned this pull request Feb 24, 2023
Closed
@anmonteiro
move stdlib_labels to stdlib_modules and compile with -nolabels
4c480ff
@anmonteiro
Add stdlib dune files
1a650e3
@anmonteiro
Install runtime artifacts in $LIBDIR/__MELANGE_RUNTIME__
f501cae
@anmonteiro
remove data_only_dirs / subdir
9bdf2f4
@anmonteiro
Upgrade dune version in nix
e6855fb
@anmonteiro
upgrade dune version in opam build
63bb8c6
@anmonteiro
fix nix tests
7bd5113
@anmonteiro
runtime-others -> belt, make bs_stdlib_mini a private library
d2569ba
@anmonteiro
chore: move re / res files to re_or_res
bd8a46b
@anmonteiro
chore: move es6 files to es6_tests
fbff135
@anmonteiro
chore: delete tracked js files
20a4ab7
@anmonteiro
chore: track js files in new location
9667f80
@anmonteiro
move artifacts around
ac84de2
@anmonteiro
add dune file
49e22e5
@anmonteiro
commit tests with updated runtime paths
a257ae5
@anmonteiro
add Js_config.bs_legacy to preserve the previous behavior
320c848
@anmonteiro
add -bs-legacy flag for mel compatibility
f8ff791
@anmonteiro
fix some tests
148500c
@anmonteiro
fix some tests in test/
dc0aa98
@anmonteiro
convert a few more, settle on stdlib
959e74a
@anmonteiro
commit the test directory
e31e547
@anmonteiro
commit updated require paths in tests
5b5c35e
@anmonteiro
fix dune files, commit script
203c2bf
@anmonteiro
make tests run
621cc3e
@anmonteiro
add custom dune override
b6bfb55
@anmonteiro
run tests in legacy mode too
470e0f3
@anmonteiro anmonteiro force-pushed the anmonteiro/port-tests-to-dune branch from 10ad22d to c4a7f65 Compare February 25, 2023 00:19
rizo added a commit to rizo/hello-melange-onix that referenced this pull request Feb 28, 2023
@rizo
Use melange-re/melange#493.
1e3a663
@anmonteiro anmonteiro mentioned this pull request Feb 28, 2023
Closed
@anmonteiro
Copy link
Member Author

OK, let's do this.

@anmonteiro anmonteiro merged commit 13edf61 into main Mar 3, 2023
@jchavarri jchavarri mentioned this pull request Mar 22, 2023
Closed
@anmonteiro anmonteiro mentioned this pull request May 31, 2023
Merged
anmonteiro added a commit to anmonteiro/opam-repository that referenced this pull request May 31, 2023
@anmonteiro
[new release] rescript-syntax, reactjs-jsx-ppx and melange (1.0.0)
ae6cea7 
CHANGES:

- melange: print an error message if `$MELANGELIB` is set to a directory that
  doesn't exist ([melange-re/melange#449](melange-re/melange#449))
- melange: fix bug where `--bs-module-name` didn't always affect generated JS
  file casing ([melange-re/melange#446](melange-re/melange#446))
- melange: fix bug where `-o output.js` didn't always write a JavaScript file
  ([melange-re/melange#454](melange-re/melange#454))
- melange: remove the `-bs-read-cmi` flag in favor of the builtin
  `-intf-suffix` flag, standard in OCaml
  ([melange-re/melange#458](melange-re/melange#458),
  [melange-re/melange#460](melange-re/melange#460))
- melange: return an actionable error message when no output is specified
  with `-impl` / `-intf`
  ([melange-re/melange#465](melange-re/melange#465),
  [melange-re/melange#466](melange-re/melange#466))
- melange: use `Object.prototype.hasOwnProperty` in the `Caml_obj` runtime
  ([melange-re/melange#469](melange-re/melange#469))
- melange: transform
  [`NonEscapeCharacter`](https://tc39.es/ecma262/#prod-NonEscapeCharacter)
  correctly in JS strings (those written using `{js|string here|js}`)
  ([melange-re/melange#469](melange-re/melange#469))
- melange: define `MELANGE` conditional compilation variable
  ([melange-re/melange#472](melange-re/melange#472))
- melange: Make `Pervasives` exactly match the `Stdlib` behavior
  ([melange-re/melange#476](melange-re/melange#476))
- melange: fix unbound error when trying to use `Printexc.exn_slot_id`
  ([melange-re/melange#482](melange-re/melange#482))
- melange: fix codegen issue accessing a nested module path that is also
  `include`d ([melange-re/melange#487](melange-re/melange#487))
- melange: preserve the correct command-line order for load path directories
  ([melange-re/melange#492](melange-re/melange#492))
- melange: respect the `-nostdlib` option; don't add stdlib / runtime to the
  load path in that case
  ([melange-re/melange#496](melange-re/melange#496))
- melange: build the Melange runtime / stdlib / runtime tests with the dune
  integration ([melange-re/melange#493](melange-re/melange#493)). Thus
  melange now requires Dune 3.8.
- melange: allow shadowing sub-modules of Stdlib in user projects
  ([melange-re/melange#512](melange-re/melange#512))
- melange, reactjs-jsx-ppx: introduce a `reactjs-jsx-ppx` package, remove its
  dependency from melange
  ([melange-re/melange#517](melange-re/melange#517))
- melange: remove the `--bs-jsx <version>` flag from `melc` now that
  `reactjs-jsx-ppx` is a separate package
  ([melange-re/melange#525](melange-re/melange#525))
- melange: add `melpp` executable to preprocess `#if` conditionals with the
  melange parser ([melange-re/melange#539](melange-re/melange#539))
- mel: delete the `mel` package. The dune integration is now the only
  officially supported workflow for orchestrating melange builds
  ([melange-re/melange#546](melange-re/melange#546))
- melange: Extract `melange.ppx` from the melange package. This preprocessing
  step interprets extensions such as `%bs.obj`, `%bs.raw`, `%bs.re`, etc.
  ([melange-re/melange#534](melange-re/melange#534))
- melange: allow installing melange in more OCaml versions and compiler
  switches. Melange now migrates binary AST to the version it understands
  ([melange-re/melange#548](melange-re/melange#548))
- melange: don't run anonymous args function from
  `[@@@bs.config {flags = [| ... |]}]` attributes
  ([melange-re/melange#554](melange-re/melange#554))
- melange: add `--preamble` flag to add a preamble to emitted JS. An example is
  `"use client";` in React Server Components, which needs to appear before
  imports ([melange-re/melange#545](melange-re/melange#545),
  [melange-re/melange#574](melange-re/melange#574))
- melange: turn off warning 20 (`ignore-extra-argument`) by default. This
  warning is rarely useful in Melange due to false positives when invoking
  functions defined with `%bs.raw`
  ([melange-re/melange#488](melange-re/melange#488),
  [melange-re/melange#576](melange-re/melange#576))
@anmonteiro anmonteiro deleted the anmonteiro/port-tests-to-dune branch September 12, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anmonteiro