-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Coq] (stdlib no)
broken since 3.8.0
#8958
Comments
The fact that |
An issue for this already exists: coq/coq#16295 |
I'm going to recreate the issue you ran into and see if I can make a reproduction case without the special setup. What's weird is that rereading the code, it seems there should be a fail-safe for when config fails, so I'm not sure what exactly is failing here just yet. |
I've chased down the issue some more and it now appears that |
Ah, good find! I should note that |
Good find @Alizter ! Indeed we need to be a bit more defensive on this side, and fix Coq upstream of course! |
Thanks @LasseBlaauwbroek for the report by the way; we have a couple more open issues pending for composed / (no stdlib) builds; that means that indeed we are blocked on our own projects to dune 3.7 I hope to be able to have some time for this soon. |
I have tests and fixes ready for this, just need some time to clean them up. |
CHANGES: - Introduce `$ dune ocaml doc` to open and browse documentation. (ocaml/dune#7262, fixes ocaml/dune#6831, @EmileTrotignon) - `dune cache trim` now accepts binary byte units: `KiB`, `MiB`, etc. (ocaml/dune#8618, @Alizter) - No longer force colors for OCaml 4.03 and 4.04 (ocaml/dune#8778, @rgrinberg) - Introduce new experimental odoc rules (ocaml/dune#8803, @jonjudlam) - Introduce the `runtest_alias` field to the `cram` stanza. This allows removing default `runtest` alias from tests. (@rgrinberg, ocaml/dune#8887) - Do not ignore libraries named `bigarray` when they are defined in conjunction with OCaml 5.0 (ocaml/dune#8902, fixes ocaml/dune#8901, @rgrinberg) - Dependencies in the copying sandbox are now writeable (ocaml/dune#8920, @rgrinberg) - Absent packages shouldn't prevent all rules from being loaded (ocaml/dune#8948, fixes ocaml/dune#8630, @rgrinberg) - Correctly determine the stanza of menhir modules when `(include_subdirs qualified)` is enabled (@rgrinberg, ocaml/dune#8949, fixes ocaml/dune#7610) - Display cache location in Dune log (ocaml/dune#8974, @nojb) - Re-run actions whenever `(expand_aliases_in_sandbox)` changes (ocaml/dune#8990, @rgrinberg) - Rules that only use internal dune actions (`write-file`, `echo`, etc.) can now be sandboxed. (ocaml/dune#9041, fixes ocaml/dune#8854, @rgrinberg) - Do not re-run rules when their location changes (ocaml/dune#9052, @rgrinberg) - Correctly ignore `bigarray` on recent version of OCaml (ocaml/dune#9076, @rgrinberg) - Add `test_` prefix to default test name in `dune init project` (ocaml/dune#9257, fixes ocaml/dune#9131, @9sako6) - Add `coqdoc_flags` field to `coq` field of `env` stanza allowing the setting of workspace-wide defaults for `coqdoc_flags`. (ocaml/dune#9280, fixes ocaml/dune#9139, @Alizter) - [coq rules] Be more tolerant when coqc --print-version / --config don't work properly, and fallback to a reasonable default. This fixes problems when building Coq projects with `(stdlib no)` and likely other cases. (ocaml/dune#8966, fix ocaml/dune#8958, @Alizter, reported by Lasse Blaauwbroek) - Dune will now run at a lower framerate of 15 fps rather than 60 when `INSIDE_EMACS`. (ocaml/dune#8812, @Alizter) - dune-build-info: when `version=""` is found in a `META` file, we now return `None` as a version string (ocaml/dune#9177, @emillon) - Dune can now be built and installed on Haiku (ocaml/dune#8795, fix ocaml/dune#8551, @Alizter) - Mark installed directories in `dune-package` files. This fixes `(package)` dependencies against packages that contain such directories. (ocaml/dune#8953, fixes ocaml/dune#8915, @emillon)
[Tactician] Upgrade minimum dune after fix of ocaml/dune#8958
Starting with Dune 3.8.0, due to #6563, dune can no longer build in
(stdlib no)
mode when the stdlib is not installed. This is because it is checkingcoqc --config
, which gives an exit code of 1. It has always done that, but Dune didn't seem to check it before 3.8.0Reproduction
We can reproduce the problem with Dune's own tests.
coq-core.8.18.0
installed, but notcoq-stdlib
!DUNE_COQ_TEST=enable ./dune.exe build @no-stdlib
outputs:git checkout 3.7.1
and run the tests again, you will see that they succeed.CC @ejgallego @Alizter
The text was updated successfully, but these errors were encountered: