Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tactician] Upgrade minimum dune after fix of ocaml/dune#8958 #3014

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

LasseBlaauwbroek
Copy link
Member

No description provided.

@silene
Copy link
Contributor

silene commented Apr 11, 2024

Note that, despite the "success" status of the CI, it never succeeded in installing any of the packages. (I suppose that we should at least tweak the build:any job, so that it becomes an error if it installed nothing, rather than a vacuous success.)

@LasseBlaauwbroek
Copy link
Member Author

Indeed. I don't really understand what is going on anyway. The logs say that the package cannot be installed with the current compiler. But then, the subsequent message says that the package can be installed without changing to another compiler....

@silene
Copy link
Contributor

silene commented Apr 11, 2024

This is just a wild guess, but I think you are confusing opam by having a dependency on opam-client. As a consequence, it would have to reinstall itself on the fly to succeed, which I guess it really does not want to do.

@LasseBlaauwbroek
Copy link
Member Author

I had forgotten to update some requirements, leading to no solution existing. The tests pass now (non-vacuously).

@silene silene merged commit 93cc8bd into coq:master Apr 11, 2024
3 checks passed
@LasseBlaauwbroek LasseBlaauwbroek deleted the tactician-upgrade-dune branch April 11, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants