-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UBERON:0002820 needs to be split into two classes #1357
Comments
tgbugs
added a commit
to SciCrunch/NIF-Ontology
that referenced
this issue
Sep 10, 2017
This is a hefty commit that makes some fundamental changes to reconcile the anatomical modellingin NIFGA and UBERON. The major changes are 1. Removal of has_proper_part and proper_part_of axioms that asserted that parts of the peripheral nervous sytem were part of the central nervous system. These were removed in both nifga proper and uberon-bridge where they had perviously been ported. 2. Removal of disjointness axioms between Regional part of X and X that conflict with uberon's modelling where a part of X can also be sco X. 3. Relaxation of sco hierarchy (usually in the regional part of x which has been deprecated in uberon) to avoid part of pns vs part of cns disjointness in uberon (related to 1). Two additional changes have been made. 1. The local copy of uberon.owl has been patched to reflect the changes discussed in obophenotype/uberon#1356. 2. The label of BIRNLEX:2529 was updated to correct an ancient copy and paste error so that it now properly matchs UMLS:C1184863. @cmungall See obophenotype/uberon#1357 for refernce. This is part 1 of the changes. The additional changes are a bit deeper and either require changes to uberon-bridge-to-nifstd or something much deeper due to conflicts between acellular and multicellular parts.
cmungall
added a commit
that referenced
this issue
Sep 10, 2017
also added grouping class for zonas pectinata and arcuate Placed UMLS xrefs in correct place. Hopefully places nlx IDs also in correct place Fixes #1357
tgbugs
added a commit
to SciCrunch/NIF-Ontology
that referenced
this issue
Jan 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
UBERON:0002820
seems to have been copied from NIFGA which contained a copy and paste error that falsely equatedUMLS:C1184862
->Zona arcuata of basilar membrane of cochlea
andUMLS:C1184863
->Zona pectinata of basilar membrane of cochlea
. Given the current equivalent class mappings to NIFGA I recommend thatUMLS:C1184863
->Zona pectinata of basilar membrane of cochlea
be created as a new class and point toBIRNLEX:2529
consistent with the recent change to NIFGA. http://purl.obolibrary.org/obo/uberon/bridge/uberon-bridge-to-nifstd.owl should be updated as well.The text was updated successfully, but these errors were encountered: