Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with modelling of UBERON:0001877 medial septal nucleus #1356

Closed
tgbugs opened this issue Sep 10, 2017 · 3 comments
Closed

issue with modelling of UBERON:0001877 medial septal nucleus #1356

tgbugs opened this issue Sep 10, 2017 · 3 comments

Comments

@tgbugs
Copy link
Contributor

tgbugs commented Sep 10, 2017

The definition of UBERON:0001877 leads to incorrect classification of UBERON:0001879 (nucleus of diagonal band) as a subClassOf UBERON:0001877. This error was encountered while trying to resolve conflicts between modelling of NIFGA and Uberon, where we have a disjointness axiom between the two. A brief review of the Allen atlases shows that 'nucleus of diagonal band' is not a sub class of 'medial septal nucleus' despite being part of the medial septal complex. There are a number of changes required to correct the issue: 1) removal of UBERON:0001879 rdfs:subClassOf UBERON:0001877 2) removal of

UBERON:0001877 owl:equivalentClass [ a owl:Class ;
                                     owl:intersectionOf (
                                       UBERON:0002308
                                       [ a owl:Restriction ;
                                         owl:onProperty BFO:0000050 ;
                                         owl:someValuesFrom UBERON:0007629 ] ) ]

so that when we add 3) UBERON:0001879 rdfs:subClassOf UBERON:0002308 the misclassification does not happen again (the part of restriction is already present).

Including @memartone for reference.

@cmungall
Copy link
Member

Agreed. The equivalence axiom will be relaxed to a subclass (i.e. 2+3). This will automatically remove 1, since 1 is inferred.

@cmungall
Copy link
Member

While we're here, any proposed definition for MSC? BrainInfo has a rat-centric def: http://braininfo.rprc.washington.edu/centraldirectory.aspx?ID=1958

@tgbugs
Copy link
Contributor Author

tgbugs commented Sep 10, 2017

It does not seem that the terminology of 'medial septal complex' is used in humans.

Andy 68 seems to be the only reference to a human NDB and the definitive work on what we might call the MSC. Plate 4 on page 401 (aka 19) figures 22, and 23 seem to indicate that NDB (BD in the plate) and MSN (MA, MP in the plate) are directly adjacent to each other (at least at some point) similar to how they are in the rat. Given all this I think it is probably ok to use to definition provided in the rat, with an addition, maybe: def: "A septal nuclear complex that consists of the nucleus of the diagonal bands and the septal medial nuclei. This term is mainly used in the rat. While this term is not used in the human, the spatial relationship between its components in the human suggests that the term also applies."

Here are annotations from the most recent works I can found that were trying to reconcile MRI studies with histology https://hyp.is/jXZG-JXPEeetgPOvfI0SDw/www.ncbi.nlm.nih.gov/pmc/articles/PMC4180657/ https://hyp.is/rXX3CpXPEee0EQ8-M_UddQ/www.ncbi.nlm.nih.gov/pmc/articles/PMC2577158/.

There is some overlapping nomenclature for the MSN here https://hyp.is/ow2JopXREeeYiAsiGxVYDA/www.ncbi.nlm.nih.gov/pmc/articles/PMC4175400/ with MSN -> Ch1 but nothing going to NDB directly, only the limbs of the diagonal bands.

tgbugs added a commit to SciCrunch/NIF-Ontology that referenced this issue Sep 10, 2017
This is a hefty commit that makes some fundamental changes to reconcile
the anatomical modellingin NIFGA and UBERON. The major changes are
1. Removal of has_proper_part and proper_part_of axioms that asserted
that parts of the peripheral nervous sytem were part of the central
nervous system. These were removed in both nifga proper and
uberon-bridge where they had perviously been ported.
2. Removal of disjointness axioms between Regional part of X and X that
conflict with uberon's modelling where a part of X can also be sco X.
3. Relaxation of sco hierarchy (usually in the regional part of x which
has been deprecated in uberon) to avoid part of pns vs part of cns
disjointness in uberon (related to 1).

Two additional changes have been made.
1. The local copy of uberon.owl has been patched to reflect the changes
discussed in obophenotype/uberon#1356.
2. The label of BIRNLEX:2529 was updated to correct an ancient copy and
paste error so that it now properly matchs UMLS:C1184863. @cmungall
See obophenotype/uberon#1357 for refernce.

This is part 1 of the changes. The additional changes are a bit deeper
and either require changes to uberon-bridge-to-nifstd or something much
deeper due to conflicts between acellular and multicellular parts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants