-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/node: add consensus.backend flag #1878
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move all the tendermint backends somewhere under go/tendermint
now that this is per-consensus-backend?
Oh god please don't move the backends around till after I merge #1858. |
37a855d
to
731a96d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1878 +/- ##
==========================================
+ Coverage 53.47% 55.31% +1.84%
==========================================
Files 223 221 -2
Lines 21079 20333 -746
==========================================
- Hits 11271 11247 -24
+ Misses 8603 7893 -710
+ Partials 1205 1193 -12
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1878 +/- ##
==========================================
+ Coverage 53.47% 54.44% +0.97%
==========================================
Files 223 222 -1
Lines 21079 20685 -394
==========================================
- Hits 11271 11261 -10
+ Misses 8603 8219 -384
Partials 1205 1205
Continue to review full report at Codecov.
|
Fixes: #1870
Done:
consensus.backend
flagepochtime
backend will be taken care of in #1793TODO (after merging/before promoting):