Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/node: add consensus.backend flag #1878

Merged
merged 2 commits into from
Jul 1, 2019

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Jul 1, 2019

Fixes: #1870

Done:

  • removes trivial scheduler
  • introduces consensus.backend flag

epochtime backend will be taken care of in #1793

TODO (after merging/before promoting):

  • fix flags in chart
  • fix flags in runtime-ethereum

Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move all the tendermint backends somewhere under go/tendermint now that this is per-consensus-backend?

@Yawning
Copy link
Contributor

Yawning commented Jul 1, 2019

Oh god please don't move the backends around till after I merge #1858.

@ptrus ptrus force-pushed the ptrus/feature/cleanup-consensus-backends branch from 37a855d to 731a96d Compare July 1, 2019 12:05
@codecov
Copy link

codecov bot commented Jul 1, 2019

Codecov Report

Merging #1878 into master will increase coverage by 1.84%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1878      +/-   ##
==========================================
+ Coverage   53.47%   55.31%   +1.84%     
==========================================
  Files         223      221       -2     
  Lines       21079    20333     -746     
==========================================
- Hits        11271    11247      -24     
+ Misses       8603     7893     -710     
+ Partials     1205     1193      -12
Impacted Files Coverage Δ
go/registry/tendermint/tendermint.go 69.27% <ø> (ø) ⬆️
go/beacon/tendermint/tendermint.go 66.25% <ø> (ø) ⬆️
go/staking/tendermint/tendermint.go 60.11% <ø> (+2.89%) ⬆️
go/epochtime/tendermint/tendermint.go 0% <ø> (ø) ⬆️
go/tendermint/api/api.go 37.03% <ø> (ø) ⬆️
go/keymanager/tendermint/tendermint.go 38.27% <ø> (ø) ⬆️
go/roothash/tendermint/tendermint.go 64.12% <ø> (ø) ⬆️
go/scheduler/tendermint/tendermint.go 61.22% <ø> (+4.08%) ⬆️
go/ekiden/cmd/node/node.go 52.56% <100%> (ø) ⬆️
go/ekiden/cmd/genesis/genesis.go 12.77% <100%> (+1.82%) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6a9957...731a96d. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 1, 2019

Codecov Report

Merging #1878 into master will increase coverage by 0.97%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1878      +/-   ##
==========================================
+ Coverage   53.47%   54.44%   +0.97%     
==========================================
  Files         223      222       -1     
  Lines       21079    20685     -394     
==========================================
- Hits        11271    11261      -10     
+ Misses       8603     8219     -384     
  Partials     1205     1205
Impacted Files Coverage Δ
go/registry/tendermint/tendermint.go 69.27% <ø> (ø) ⬆️
go/beacon/tendermint/tendermint.go 66.25% <ø> (ø) ⬆️
go/staking/tendermint/tendermint.go 57.21% <ø> (ø) ⬆️
go/epochtime/tendermint/tendermint.go 0% <ø> (ø) ⬆️
go/tendermint/api/api.go 37.03% <ø> (ø) ⬆️
go/keymanager/tendermint/tendermint.go 38.27% <ø> (ø) ⬆️
go/roothash/tendermint/tendermint.go 64.12% <ø> (ø) ⬆️
go/scheduler/tendermint/tendermint.go 57.14% <ø> (ø) ⬆️
go/ekiden/cmd/node/node.go 52.71% <100%> (+0.15%) ⬆️
go/ekiden/cmd/genesis/genesis.go 11.27% <100%> (+0.32%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6a9957...731a96d. Read the comment docs.

@ptrus ptrus merged commit d33c9a5 into master Jul 1, 2019
@ptrus ptrus deleted the ptrus/feature/cleanup-consensus-backends branch July 1, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up non-tm backends removal
3 participants