Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More staking work #1858

Merged
merged 6 commits into from
Jul 1, 2019
Merged

More staking work #1858

merged 6 commits into from
Jul 1, 2019

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Jun 26, 2019 •
edited
Loading

Splitting this into multiple PRs to prevent this from getting huge, see #1877 for followup work.

  • The staking ABCI app needs to be high priority.
  • Grant the TestEntity sufficient stake for testing.
  • Extend the genesis format.
    • Full account ledger instead of just initial balance.
    • Common pool status.
  • Staking backend needs a gRPC interface.
  • Expand the staking interfaces to support planned policy.
    • Stake slashing should be a burn to a common pool.
      • Add a common pool.
      • Add internal ABCI state interfaces for manipulating the escrowed amount.
    • Interfaces for shuffling funds into/out of the common pool.

@Yawning Yawning added p:1 Priority: core feature golang labels Jun 26, 2019
@Yawning Yawning self-assigned this Jun 26, 2019
@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #1858 into master will decrease coverage by 0.13%.
The diff coverage is 5.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1858      +/-   ##
==========================================
- Coverage   56.99%   56.86%   -0.14%     
==========================================
  Files         240      240              
  Lines       22495    22550      +55     
==========================================
  Hits        12822    12822              
- Misses       8328     8382      +54     
- Partials     1345     1346       +1
Impacted Files Coverage Δ
go/ekiden/cmd/genesis/genesis.go 11.15% <4.54%> (-1.24%) ⬇️
go/staking/api/quantity.go 83.09% <8.33%> (-16.91%) ⬇️
go/scheduler/alg/greedy_subgraphs_scheduler.go 84.21% <0%> (-5.27%) ⬇️
go/storage/client/client.go 68.54% <0%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea9df8...ffef505. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 26, 2019 •
edited
Loading

Codecov Report

Merging #1858 into master will decrease coverage by 0.77%.
The diff coverage is 11.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1858      +/-   ##
==========================================
- Coverage   54.29%   53.51%   -0.78%     
==========================================
  Files         222      223       +1     
  Lines       20727    21079     +352     
==========================================
+ Hits        11253    11280      +27     
- Misses       8280     8596     +316     
- Partials     1194     1203       +9
Impacted Files Coverage Δ
go/staking/api/api.go 85.71% <ø> (+6.16%) ⬆️
go/ekiden/cmd/node/node.go 52.56% <100%> (+0.15%) ⬆️
go/staking/tests/tester.go 80.64% <100%> (-0.18%) ⬇️
go/tendermint/apps/staking/state.go 43.88% <12.67%> (-32.59%) ⬇️
go/staking/grpc.go 2.28% <2.28%> (ø)
go/tendermint/apps/staking/staking.go 53.8% <20.37%> (-5.39%) ⬇️
go/staking/tendermint/tendermint.go 57.21% <25%> (-2.9%) ⬇️
go/ekiden/cmd/genesis/genesis.go 10.94% <4.08%> (-1.45%) ⬇️
go/staking/api/quantity.go 85.91% <50%> (-14.09%) ⬇️
go/staking/init.go 85.71% <80%> (+1.09%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f43b27...c99e35f. Read the comment docs.

@Yawning Yawning force-pushed the yawning/feature/stake-land-ii-the-stakelander branch 4 times, most recently from 3c42f7c to 03e4b28 Compare June 28, 2019 09:04
@Yawning
Copy link
Contributor Author

Yawning commented Jun 28, 2019

Ugh, wiring staking everywhere is going to complicate unit tests something fierce.

@Yawning Yawning force-pushed the yawning/feature/stake-land-ii-the-stakelander branch 3 times, most recently from 2d5ba8b to bc56e27 Compare July 1, 2019 08:48
@Yawning Yawning changed the title WIP: More staking work More staking work Jul 1, 2019
@Yawning Yawning requested a review from kostko July 1, 2019 09:11
@Yawning Yawning marked this pull request as ready for review July 1, 2019 09:12
@Yawning Yawning requested a review from peterjgilbert as a code owner July 1, 2019 09:12
Yawning added 5 commits July 1, 2019 09:43
@Yawning
go/tendermint/apps/staking: Move the app up in priority
e026c00 
This should come before the registry.
@Yawning
go/ekiden/cmd/genesis: Wire up staking
ff96cc1 
 * Add support to the genesis tool for provisioning the stake ledger.
 * Grant the `TestEntity` One Hundred Billion Dollars *pinky finger*
   if enabled.
@Yawning
go/staking: Add gRPC bindings
7fbe72e
@Yawning
go/staking: Add CommonPool
3785393 
Burns need to be sent to a common pool.  It will help if there is a
destination for such things.
@Yawning
go/staking: Extend the genesis document
384e507
@Yawning Yawning force-pushed the yawning/feature/stake-land-ii-the-stakelander branch from bc56e27 to 0dd22a9 Compare July 1, 2019 09:43
kostko
kostko reviewed Jul 1, 2019
View reviewed changes
@Yawning
go/tendermint/apps/staking: Add escrow/common pool routines
c99e35f 
There needs to be ways to slash/release escrow, and transfer funds from
the common pool to accounts.
@Yawning Yawning force-pushed the yawning/feature/stake-land-ii-the-stakelander branch from 0dd22a9 to c99e35f Compare July 1, 2019 10:45
@Yawning Yawning mentioned this pull request Jul 1, 2019
Merged
@Yawning Yawning merged commit c6a9957 into master Jul 1, 2019
@Yawning Yawning deleted the yawning/feature/stake-land-ii-the-stakelander branch July 1, 2019 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko approved these changes

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

Assignees

@Yawning Yawning

Labels
golang p:1 Priority: core feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yawning @kostko