Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change the permissions for /var/lib/leapp directory from '755' to '700' #807

Merged
merged 1 commit into from
Jan 18, 2023
Merged

change the permissions for /var/lib/leapp directory from '755' to '700' #807

merged 1 commit into from
Jan 18, 2023

Conversation

PeterMocary
Copy link
Member

@PeterMocary PeterMocary commented Dec 21, 2022 •
edited
Loading

The nature of the content stored in the /var/lib/leapp directory requires stricter permissions.

@github-actions
Copy link

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please to notify leapp developers of review request
  • /packit copr-build to submit a public copr build using packit

To launch regression testing public members of oamg organization can leave the following comment:

  • /rerun to schedule basic regression tests using this pr build and leapp-repository*master* as artifacts
  • /rerun 42 to schedule basic regression tests using this pr build and leapp-repository*PR42* as artifacts
  • /rerun-sst to schedule sst tests using this pr build and leapp-repository*master* as artifacts
  • /rerun-sst 42 to schedule sst tests using this pr build and leapp-repository*PR42* as artifacts

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

@PeterMocary PeterMocary requested a review from Rezney December 21, 2022 22:16
@fernflower
Copy link
Member

/rerun

fernflower
fernflower approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@fernflower fernflower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/5165822

@github-actions
Copy link

Testing Farm request for RHEL-7.9-rhui/5149673;5165822 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

Testing Farm request for RHEL-8.6-rhui/5149673;5165822 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

Testing Farm request for RHEL-8.6.0-Nightly/5149673;5165822 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

Testing Farm request for RHEL-8.7.0-Nightly/5149673;5165822 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

Testing Farm request for RHEL-7.9-ZStream/5149673;5165822 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

Testing Farm request for RHEL-7.9-ZStream/5149673;5165822 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@fernflower
Copy link
Member

Okay, the single failing test is happening because of #808 . The patch is fine, the initram functionality and the test itself is fine too.

@fernflower
Copy link
Member

/rerun

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/5204219

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Testing Farm request for RHEL-8.6-rhui/5201672;5204219 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Testing Farm request for RHEL-7.9-rhui/5201672;5204219 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Testing Farm request for RHEL-8.6.0-Nightly/5201672;5204219 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Testing Farm request for RHEL-8.7.0-Nightly/5201672;5204219 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Testing Farm request for RHEL-7.9-ZStream/5201672;5204219 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Testing Farm request for RHEL-7.9-ZStream/5201672;5204219 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@fernflower fernflower merged commit 895caae into oamg:master Jan 18, 2023
@pirat89 pirat89 added the changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant label Jan 25, 2023
pirat89 added a commit to pirat89/leapp that referenced this pull request Feb 21, 2023
@pirat89
# Release 0.15.1
0fbfb7c 
## Packaging
-  Change permissions for /var/lib/leapp to 0700 (oamg#807)

## Framework
### Fixes
- Prevent unicode errors when printing error messages (oamg#806)
- Make checks for missing answers more strict (oamg#797)

### Enhancements
- Expose tracebacks from actors (oamg#802)

### Known issue
- introduced new known issue in framework...
@pirat89 pirat89 mentioned this pull request Feb 21, 2023
Merged
pirat89 added a commit to pirat89/leapp that referenced this pull request Feb 21, 2023
@pirat89
# Release 0.15.1
0f1352d 
## Packaging
-  Change permissions for /var/lib/leapp to 0700 (oamg#807)

## Framework
### Fixes
- Prevent unicode errors when printing error messages (oamg#806)
- Make checks for missing answers more strict (oamg#797)

### Enhancements
- Expose tracebacks from actors (oamg#802)
pirat89 added a commit to pirat89/leapp that referenced this pull request Feb 21, 2023
@pirat89
# Release 0.15.1
b3e030f 
## Packaging
-  Change permissions for /var/lib/leapp to 0700 (oamg#807)

## Framework
### Fixes
- Prevent unicode errors when printing error messages (oamg#806)
- Make checks for missing answers more strict (oamg#797)

### Enhancements
- Expose tracebacks from actors (oamg#802)
pirat89 added a commit to pirat89/leapp that referenced this pull request Feb 21, 2023
@pirat89
# Release 0.15.1
e334324 
## Packaging
-  Change permissions for /var/lib/leapp to 0700 (oamg#807)

## Framework
### Fixes
- Make checks for missing answers more strict (oamg#797)
- Prevent unicode errors when printing error messages (oamg#806)

### Enhancements
- Expose tracebacks from actors (oamg#802)
pirat89 added a commit that referenced this pull request Feb 21, 2023
@pirat89
# Release 0.15.1
86622ce 
## Packaging
-  Change permissions for /var/lib/leapp to 0700 (#807)

## Framework
### Fixes
- Make checks for missing answers more strict (#797)
- Prevent unicode errors when printing error messages (#806)

### Enhancements
- Expose tracebacks from actors (#802)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fernflower fernflower fernflower approved these changes

@Rezney Rezney Awaiting requested review from Rezney

Assignees
No one assigned
Labels
changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeterMocary @fernflower @pirat89