Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make checks for missing answers more strict #797

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Make checks for missing answers more strict #797

merged 1 commit into from
Sep 8, 2022

Conversation

fernflower
Copy link
Member

Previously only presence of one section in the answerfile
has been verified, which led to false-positive preupgrade
reports when some other key has been present in the
dialog section instead of the required one.

OAMG-7521

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please to notify leapp developers of review request
  • /packit copr-build to submit a public copr build using packit

To launch regression testing public members of oamg organization can leave the following comment:

  • /rerun to schedule basic regression tests using this pr build and leapp-repository*master* as artifacts
  • /rerun 42 to schedule basic regression tests using this pr build and leapp-repository*PR42* as artifacts
  • /rerun-all to schedule all tests (including sst) using this pr build and leapp-repository*master* as artifacts
  • /rerun-all 42 to schedule all tests (including sst) using this pr build and leapp-repository*PR42* as artifacts

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

@centos-ci
Copy link

Can one of the admins verify this patch?

@fernflower fernflower requested a review from pirat89 September 6, 2022 13:31
@fernflower fernflower force-pushed the fixanswerfilepresentsectionnokey branch from 29a24a5 to 6901f64 Compare September 6, 2022 13:37
@fernflower
Copy link
Member Author

/rerun

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/4812344

@fernflower
Copy link
Member Author

@pirat89 This should be it.

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Testing Farm request for RHEL-8.6-rhui/4801151;4812344 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Testing Farm request for RHEL-7.9-rhui/4801151;4812344 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@fernflower fernflower force-pushed the fixanswerfilepresentsectionnokey branch from 6901f64 to 9a4890e Compare September 6, 2022 14:25
@fernflower
Make checks for missing answers more strict
9457a68 
Previously only presence of one section in the answerfile
has been verified, which led to false-positive preupgrade
reports when some other key has been present in the
dialog section instead of the required one.

OAMG-7521
@fernflower fernflower force-pushed the fixanswerfilepresentsectionnokey branch from 9a4890e to 9457a68 Compare September 6, 2022 14:33
pirat89
pirat89 approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@pirat89 pirat89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and works as exepcted. Additional discovered issues (unrelated to this bug) will be handled properly as part of OAMG-7521 and OAMG-7525. Waiting for the finished CI test, preapred for merging

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Testing Farm request for RHEL-8.7.0-Nightly/4801151;4812344 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Testing Farm request for RHEL-8.6.0-Nightly/4801151;4812344 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Testing Farm request for RHEL-7.9-ZStream/4801151;4812344 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Testing Farm request for RHEL-7.9-ZStream/4801151;4812344 regression testing has been created.
Once finished, results should be available here.
Full pipeline log.

@pirat89 pirat89 merged commit 84de08e into oamg:master Sep 8, 2022
pirat89 added a commit to pirat89/leapp that referenced this pull request Feb 21, 2023
@pirat89
# Release 0.15.1
0fbfb7c 
## Packaging
-  Change permissions for /var/lib/leapp to 0700 (oamg#807)

## Framework
### Fixes
- Prevent unicode errors when printing error messages (oamg#806)
- Make checks for missing answers more strict (oamg#797)

### Enhancements
- Expose tracebacks from actors (oamg#802)

### Known issue
- introduced new known issue in framework...
@pirat89 pirat89 added the changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant label Feb 21, 2023
@pirat89 pirat89 mentioned this pull request Feb 21, 2023
Merged
pirat89 added a commit to pirat89/leapp that referenced this pull request Feb 21, 2023
@pirat89
# Release 0.15.1
0f1352d 
## Packaging
-  Change permissions for /var/lib/leapp to 0700 (oamg#807)

## Framework
### Fixes
- Prevent unicode errors when printing error messages (oamg#806)
- Make checks for missing answers more strict (oamg#797)

### Enhancements
- Expose tracebacks from actors (oamg#802)
pirat89 added a commit to pirat89/leapp that referenced this pull request Feb 21, 2023
@pirat89
# Release 0.15.1
b3e030f 
## Packaging
-  Change permissions for /var/lib/leapp to 0700 (oamg#807)

## Framework
### Fixes
- Prevent unicode errors when printing error messages (oamg#806)
- Make checks for missing answers more strict (oamg#797)

### Enhancements
- Expose tracebacks from actors (oamg#802)
pirat89 added a commit to pirat89/leapp that referenced this pull request Feb 21, 2023
@pirat89
# Release 0.15.1
e334324 
## Packaging
-  Change permissions for /var/lib/leapp to 0700 (oamg#807)

## Framework
### Fixes
- Make checks for missing answers more strict (oamg#797)
- Prevent unicode errors when printing error messages (oamg#806)

### Enhancements
- Expose tracebacks from actors (oamg#802)
pirat89 added a commit that referenced this pull request Feb 21, 2023
@pirat89
# Release 0.15.1
86622ce 
## Packaging
-  Change permissions for /var/lib/leapp to 0700 (#807)

## Framework
### Fixes
- Make checks for missing answers more strict (#797)
- Prevent unicode errors when printing error messages (#806)

### Enhancements
- Expose tracebacks from actors (#802)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirat89 pirat89 pirat89 approved these changes

Assignees
No one assigned
Labels
changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fernflower @centos-ci @pirat89