Do not require a leading dot for JSON field paths #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/kubernetes/community/blob/ddc11a7/contributors/devel/sig-architecture/api-conventions.md#selecting-fields This allows us to leverage existing libraries and patterns designed for Kubernetes field paths. (cherry picked from commit 72eecb6)
… fieldPaths This ensures that all examples and documentation reflect the current status of the OAM spec following the removal of the leading dot from field paths in order to leverage existing Kubernetes libraries. Signed-off-by: hasheddan <[email protected]>
hasheddan
requested review from
hongchaodeng,
resouer,
technosophos and
vturecek
as code owners
|
|
hasheddan
commented
Apr 5, 2020
Comment on lines
+208
to
+209
| 1. Embed a valid OAM workload kind under its `spec.workload` field. | ||
| 2. Publish a set of parameters under its `spec.parameters` field. Parameters may |
There was a problem hiding this comment.
Note: these updates are not strictly needed here, but I thought it would be a good idea to mirror the convention we are standardizing on for JSON field paths.
wonderflow
approved these changes
Apr 6, 2020
|
@wonderflow can this be merged? |
|
Yes, LGTM, sorry for missed this one! We also need to check implementation side carefully for this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks 72eecb6 from the
1.0.0-alpha2branch and updates all documentation and examples to reflect the removal of the leading dot from JSON field paths.Ref: #345