Don't require a leading dot for JSON field paths #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/kubernetes/community/blob/ddc11a7/contributors/devel/sig-architecture/api-conventions.md#selecting-fields This allows us to leverage existing libraries and patterns designed for Kubernetes field paths.
negz
requested review from
hongchaodeng,
resouer,
technosophos and
vturecek
as code owners
|
Ref #335 If this is a written k8s convention, we should follow and add a line in the spec. Also need to update examples and design doc. |
|
Ping. Does this seem uncontroversial enough to merge? |
hasheddan
approved these changes
Apr 3, 2020
There was a problem hiding this comment.
@hongchaodeng I am happy to follow this with any clean-up that needs to happen in the docs 👍
|
/lgtm This one is good enough to merge. Thorough fix could be done by follow up PRs. |
|
@hasheddan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/kubernetes/community/blob/ddc11a7/contributors/devel/sig-architecture/api-conventions.md#selecting-fields
This allows us to leverage existing libraries and patterns designed for Kubernetes field paths, per crossplane/crossplane-runtime#136.