Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requestFullscreen() doesn't work outside of a user gesture #7566

Closed
AshleyScirra opened this issue Sep 7, 2020 · 1 comment
Closed

requestFullscreen() doesn't work outside of a user gesture #7566

AshleyScirra opened this issue Sep 7, 2020 · 1 comment
Assignees
@rogerwang

Comments

@AshleyScirra
Copy link

AshleyScirra commented Sep 7, 2020 •
edited
Loading

NWJS Version : v0.48.1
Operating System : Windows 10 x64

Expected behavior

The Fullscreen API (requestFullscreen()) should work at any time in NW.js.

Actual behavior

It appears to be limited to user gestures only, like in the Chrome browser.

How to reproduce

Minimal repro:
fullscreenerror.zip

This just calls document.documentElement.requestFullscreen(); on startup. However this fails to put the window in to fullscreen mode, and fires a "fullscreenerror" event.

I'm fairly sure this used to work, so I suspect it is a regression at some point.
@AshleyScirra AshleyScirra mentioned this issue Sep 7, 2020
Closed
@TheRealDannyyy TheRealDannyyy mentioned this issue Sep 7, 2020
Closed
@rogerwang rogerwang self-assigned this Sep 13, 2020
@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build.

rogerwang added a commit that referenced this issue Sep 13, 2020
@rogerwang
src: Fix #7566: Enter fullscreen by script in Node frame
18aaed1 
nwjs/chromium.src@e34f0f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rogerwang rogerwang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rogerwang @AshleyScirra