Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performing browser close action stopped working in NWjs v0.46.3+ #7542

Closed
TheRealDannyyy opened this issue Aug 12, 2020 · 9 comments
Closed
Assignees

Comments

@TheRealDannyyy
Copy link

TheRealDannyyy commented Aug 12, 2020

NWJS Version: v0.46.3+
Operating System: Windows 10

Expected behavior

Basic browser actions like closing or requesting fullscreen, leads to NWjs freezing or not working as expected.

Actual behavior

It should work like it did in NWjs versions prior to v0.46.3.

How to reproduce

  1. Download NWjs v0.46.3+
  2. Extract and run package.zip
  3. Press "close" or ESCAPE key to performance basic browser close
  4. Notice application freezing and not closing as expected
@TheRealDannyyy
Copy link
Author

It could be related to the browser permissions system but not sure. Can't debug it myself.

@TheRealDannyyy
Copy link
Author

TheRealDannyyy commented Aug 21, 2020

@rogerwang Would you mind looking into this? It's affecting several Construct users and we'd like to keep using general browser actions instead of using NWjs specific ones. I'm open for any questions regarding this issue.

@rogerwang rogerwang self-assigned this Aug 21, 2020
@TheRealDannyyy
Copy link
Author

TheRealDannyyy commented Sep 7, 2020

This issue is probably related to #7566 but that issue only covers the fullscreen action.

@avishaymizrav
Copy link

I just encountered this bug too, it actually starts from 0.46.0, 0.45.6 still works for me.

@rogerwang
Copy link
Member

Could you please provide another sample? Yours is a big minified JS file and it's not clear what it is doing.

@avishaymizrav
Copy link

Could you please provide another sample? Yours is a big minified JS file and it's not clear what it is doing.

Here's one, touch the close text or press esc to send close browser request.
package.zip

@rogerwang
Copy link
Member

@avishaymizrav yours are no different...

@TheAresjej
Copy link

#7629 - maybe this will help 😋

@TheRealDannyyy
Copy link
Author

TheRealDannyyy commented Jan 18, 2021

I just tested this again with a minimal repro and it seems to be caused by the game engine (Construct 2).
Not sure why, would have to get in contact with the game engine developer.

@TheRealDannyyy TheRealDannyyy changed the title Performing basic browser actions stopped working in NWjs v0.46.3+ Performing browser close action stopped working in NWjs v0.46.3+ Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants