Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New window created using window.open not honouring height and width #5517

Closed
silentsakky opened this issue Dec 1, 2016 · 18 comments
Closed
Assignees

Comments

@silentsakky
Copy link

When creating new window using window.open it opens window with fixed height/width and doesn't honour passed height/width

  • State which version are you using - 0.14.7 SDK
  • State which OS version are you running with - OSX El Capitan
  • Provide a reproducible case if possible - code attached here
    window-open.zip
@ghostoy ghostoy self-assigned this Dec 5, 2016
@leyaya
Copy link

leyaya commented Dec 27, 2016

I met the same problem, your problem has been solved? How do you solve?

@MaherFa
Copy link

MaherFa commented Jan 3, 2017

I have the same Issue
Version 0.19.4 (both sdk and production)
OS Windows 10 Pro 64-bit, tried with ia32 and x64
Code
nw.Window.open('index.html', { title: 'Title Goes Here', position: 'center', focus: true, min_width: 1024, min_height: 768, fullscreen: true }, function(win) {});
using min_width & min_height or just width & height or even using both have no effect on the issue.
created window in my case is 1024px × 799px.
as you can see width seems to be respected in my case but the height is not.

@ghostoy
Copy link
Member

ghostoy commented Jan 17, 2017

@HUN73R13 Your issue is Windows specific upstream bug. See #5337.

@silentsakky
Copy link
Author

I don't think so, I am able to reproduce issue in Mac OS also
and upstream bug is related to height/width is off by some pixels then the passed height/width, but my issue is that whatever height/width you are passing it is showing popup with fixed height/width only, it is just ignoring the passed sizes

@ghostoy
Copy link
Member

ghostoy commented Jan 17, 2017

@silentsakky I was responding to @HUN73R13.

@silentsakky
Copy link
Author

@ghostoy Oops :)

@Christywl
Copy link
Contributor

Still reproduced on Linux/Windows with nwjs-sdk-v0.21.2.

@silentsakky
Copy link
Author

any updates on when this is going to be fixed?

@xzhan96
Copy link
Contributor

xzhan96 commented Apr 6, 2017

@rogerwang are you working on this? if not, I'd like to investigate it.

@rogerwang rogerwang assigned xzhan96 and unassigned rogerwang and ghostoy Apr 6, 2017
@xzhan96
Copy link
Contributor

xzhan96 commented Apr 6, 2017

@silentsakky your sample has the same result in chrome, did you try it on chrome?

@silentsakky
Copy link
Author

Just checked with Chrome V57.0.2987.133 (64-bit) in mac, it is opening with proper window size

@xzhan96
Copy link
Contributor

xzhan96 commented Apr 7, 2017

@Christywl please help to double check the test on Chrome on Linux, Mac and Windows.
Note that the issue is:

whatever height/width you are passing it is showing popup with fixed height/width only, it is just ignoring the passed sizes

@xzhan96
Copy link
Contributor

xzhan96 commented Apr 7, 2017

Ok, I can reproduce now.

@xzhan96
Copy link
Contributor

xzhan96 commented Apr 11, 2017

nwjs/chromium.src#77

@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build.

@xzhan96
Copy link
Contributor

xzhan96 commented Apr 12, 2017

The fix was reverted temporarily for new issue

@silentsakky
Copy link
Author

Should we reopen the issue then?

@rogerwang rogerwang reopened this Apr 12, 2017
xzhan96 added a commit to xzhan96/nw.js that referenced this issue Apr 13, 2017
Also correct some mismatch between design and implementation
rogerwang pushed a commit that referenced this issue Apr 13, 2017
Also correct some mismatch between design and implementation
rogerwang pushed a commit that referenced this issue Apr 13, 2017
Also correct some mismatch between design and implementation
@rogerwang
Copy link
Member

It is merged into nw22 branch since 0.22.0 is to be released soon and there is no further releases for 0.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants