Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5517: window.open should aware the parameters width and height #78

Closed
wants to merge 1 commit into from
Closed

Fix #5517: window.open should aware the parameters width and height #78

wants to merge 1 commit into from

Conversation

xzhan96
Copy link
Contributor

@xzhan96 xzhan96 commented Apr 13, 2017

The width/height in window.open() is higher priority than that
in package.json

@xzhan96
Fix #5517: window.open should aware the parameters width and height
b91f995 
The width/height in window.open() is higher priority than that
in package.json
@xzhan96
Copy link
Contributor Author

xzhan96 commented Apr 13, 2017 •
edited
Loading

@rogerwang PTAL
#5517

Also update the case to cover this scenario: nwjs/nw.js#5842

@xzhan96 xzhan96 closed this Apr 13, 2017
@xzhan96 xzhan96 reopened this Apr 13, 2017
rogerwang
rogerwang approved these changes Apr 13, 2017
View reviewed changes
Copy link
Member

@rogerwang rogerwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be merged into nw22 since 0.22.0 is to be released soon and there is no further releases for 0.21.

@rogerwang rogerwang closed this Apr 13, 2017
GnorTech pushed a commit that referenced this pull request Apr 26, 2017
Make MediaStreamVideoTrack::GetSettings return the track's frame rate.
b249dd2 
It is currently returning the underlying source's native frame rate,
which might be different from the adjusted rate of the track.

BUG=711273

Review-Url: https://codereview.chromium.org/2817673004
Cr-Commit-Position: refs/heads/master@{#465257}
(cherry picked from commit 935f9a2)

Review-Url: https://codereview.chromium.org/2827263002 .
Cr-Commit-Position: refs/branch-heads/3071@{#78}
Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
fujunwei pushed a commit to fujunwei/chromium.src that referenced this pull request May 22, 2017
@alancutter
Update DevTools animation timeline to handle TransitionKeyframeEffect…
3b90437 
…Models

CSS Transitions was refactored to use TransitionKeyframes instead of
AnimatableValueKeyframes in https://codereview.chromium.org/2680923005.
This patch updates the DevTools animation timeline to handle the new
data type for transitions.

BUG=698669

Review-Url: https://codereview.chromium.org/2732223002
Cr-Commit-Position: refs/heads/master@{#455333}
(cherry picked from commit a7a57ec)

Review-Url: https://codereview.chromium.org/2737263003 .
Cr-Commit-Position: refs/branch-heads/3029@{nwjs#78}
Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech pushed a commit that referenced this pull request Aug 5, 2017
@yuki3
v8binding: Fixes MutationCallback not to access the empty context.
9d2a22b 
MutationCallback holds a ScriptState and accesses it assynchronously.
So, MutationCallback should check the context if it's alive before
the uses.

[email protected]

(cherry picked from commit 659015b)

Bug: 738299
Change-Id: Ib16b37b2e90e5ba87117d7c6e1218f9df6d69a41
Reviewed-on: https://chromium-review.googlesource.com/574509
Commit-Queue: Yuki Shiino <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488611}
Reviewed-on: https://chromium-review.googlesource.com/589468
Reviewed-by: Yuki Shiino <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#78}
Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech pushed a commit that referenced this pull request Sep 14, 2017
@reveman-chromium
Change Picture: Limit random default image index
25ce179 
This limits random default image index to prevent undesirable UI
behavior when selecting an image with a high index. E.g. automatic
scrolling of picture list that is used to present default images.

always one of the first 14 images (origami avatars).

[email protected]

(cherry picked from commit 651b985)

Bug: 761641
Test: Add person and notice how the initial default image is
Change-Id: If317ed31a23b1157ad325460cb31957dee1c1b85
Reviewed-on: https://chromium-review.googlesource.com/648732
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: David Reveman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#499668}
Reviewed-on: https://chromium-review.googlesource.com/656697
Reviewed-by: David Reveman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#78}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech pushed a commit that referenced this pull request Oct 27, 2017
Fix Arc Terms of Service screen position
448d73a 
Send the updateScreenSize signal after the screen starts loading to
correct the size of inner-container.

BUG=b/65555008

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4c3db0fb419de439450b4a4bdcbaa9981849b505
Reviewed-on: https://chromium-review.googlesource.com/717722
Reviewed-by: Xiaohui Chen <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Yue Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509286}(cherry picked from commit 9921429)
Reviewed-on: https://chromium-review.googlesource.com/728463
Cr-Commit-Position: refs/branch-heads/3239@{#78}
Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang pushed a commit that referenced this pull request Jan 29, 2018
Incrementing VERSION to 65.0.3325.18
8537a0b 
[email protected]

Change-Id: Ic15b1e224ff0c9cfbb98dcde30bc2a93b3ab2caf
Reviewed-on: https://chromium-review.googlesource.com/884961
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#78}
Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech pushed a commit that referenced this pull request Mar 20, 2018
@estark37
Log console message for distrusted Symantec iframe resources
52c2ad2 
We currently log a warning message for subresources that use Symantec
certificates that have been distrusted. This message didn't fire, however, for
iframe main resources because Blink isn't notified about them in the same way
as it is other failed resource loads. To log for iframe main resources, the
logging logic is moved in RenderFrameImpl (from LocalFrameClientImpl) and
called when a frame fails to load.

This doesn't work 100% reliably for OOPIFs because of https://crbug.com/817881.

Bug: 815219
Change-Id: I961a3e664c0383a7ff81be7def6de17185501243
Reviewed-on: https://chromium-review.googlesource.com/943984
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Emily Stark <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#540727}(cherry picked from commit 97a8acc)
Reviewed-on: https://chromium-review.googlesource.com/954082
Reviewed-by: Emily Stark <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#78}
Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
VR: Allow control container to hide before showing it again
0e2c34a 
Reverts some code I thought wasn't necessary anymore in
https://chromium-review.googlesource.com/c/chromium/src/+/951926

[email protected]

(cherry picked from commit 93fa1f7)

Bug: 831332
Change-Id: Ib26d8c6e10971241905eda776d55be7407e91885
Reviewed-on: https://chromium-review.googlesource.com/1011406
Reviewed-by: Yash Malik <[email protected]>
Commit-Queue: Michael Thiessen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#550434}
Reviewed-on: https://chromium-review.googlesource.com/1016687
Reviewed-by: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#78}
Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang pushed a commit that referenced this pull request Jun 19, 2018
Download infobar : Fixed bug where infobar disappears after a while
3a6e961 
This happens due to the TabModelSelector cached by the controller getting
overwritten any time when we open a CustomTabActivity. This also doesn't
work in multi-window mode. Using the last focused activity gives us
better control of the situation in this case. Though it doesnot solve
multi-window scenario completely (as we may need to have one controller
for each activity), it is definitely better than using tab model selector.

[email protected]

(cherry picked from commit 3ee963d)

Bug: 847534
Change-Id: Ieca2c82adea89ee55894284b0eab10fc9068492d
Reviewed-on: https://chromium-review.googlesource.com/1074450
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Shakti Sahu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#562902}
Reviewed-on: https://chromium-review.googlesource.com/1081681
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#78}
Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech pushed a commit that referenced this pull request Aug 4, 2018
[ios] Revert fakebox animation change for pre-UI refresh.
16d194d 
Bug: 865408
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I43ace7047750f8754cf6882d35fd598c3fffda3a
Reviewed-on: https://chromium-review.googlesource.com/1146209
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Justin Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#577139}(cherry picked from commit 51af790)
Reviewed-on: https://chromium-review.googlesource.com/1150343
Reviewed-by: Justin Cohen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3497@{#78}
Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang pushed a commit that referenced this pull request Sep 15, 2018
Incrementing VERSION to 70.0.3538.10
98c36b9 
[email protected]

Change-Id: I2bb4987fddf27a56608fac8e99c60e5d9b8a3aaf
Reviewed-on: https://chromium-review.googlesource.com/1208420
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3538@{#78}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang pushed a commit that referenced this pull request Oct 31, 2018
Incrementing VERSION to 71.0.3578.11
6c81d97 
[email protected]

Change-Id: Ib43ac51515d81ef6e03e1630d849195471f897d9
Reviewed-on: https://chromium-review.googlesource.com/c/1285630
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#78}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang pushed a commit that referenced this pull request Dec 18, 2018
@mohamedamir
Merge "[Sync::USS] Adding the flag to enable USS Bookmarks ..." to M72
5bb1362 
Bug: 911232
Change-Id: I4813401d73ae6281fd044882c8e61869223c0911
Reviewed-on: https://chromium-review.googlesource.com/c/1359034
Commit-Queue: Mikel Astiz <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#613260}(cherry picked from commit 9e8a1f0)
Reviewed-on: https://chromium-review.googlesource.com/c/1363277
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#78}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang pushed a commit that referenced this pull request Feb 10, 2019
@steimelchrome
[Media Intent Handler] Add video/3gpp to supported MIME types
98898bb 
This fixes an issue where Chrome will only download a video/3gpp file
instead of playing it when opened with Chrome.

Bug: 910658, 923081
Change-Id: I0fcdfe5952f0020c35fe09a0db85a4e83fe4d37a
Reviewed-on: https://chromium-review.googlesource.com/c/1437720
Reviewed-by: Dale Curtis <[email protected]>
Reviewed-by: Chrome Cunningham <[email protected]>
Commit-Queue: Tommy Steimel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#626310}(cherry picked from commit 3b0ab07)
Reviewed-on: https://chromium-review.googlesource.com/c/1447253
Reviewed-by: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#78}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang pushed a commit that referenced this pull request Mar 24, 2019
Block getUserMedia on system permissions.
4ed92dd 
* New Mac functions for getting and requesting system permissions.
* Change the request queue to a map with unique IDs for the requests since the order isn't guaranteed anymore.
* Wait (async) for response from system permission request.

Bug: 885184
Change-Id: I17b046eaab51c5dd6dd57383fa23d3e7d567f809
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511401
Auto-Submit: Henrik Grunell <[email protected]>
Commit-Queue: Tommi <[email protected]>
Reviewed-by: Tommi <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#639496}(cherry picked from commit aa6b7a7cc5b5c37f288017e7451e916819b3ecc0)
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520587
Reviewed-by: Henrik Grunell <[email protected]>
Cr-Commit-Position: refs/branch-heads/3729@{#78}
Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogerwang rogerwang rogerwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xzhan96 @rogerwang