Fix C++ version of MonitorStage output issue caused by out of order function calls
#2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willkill07
reviewed
Jan 28, 2025
python/morpheus/morpheus/_lib/include/morpheus/controllers/monitor_controller.hpp
Outdated
Show resolved
Hide resolved
…itor_controller.hpp Co-authored-by: Will Killian <[email protected]>
dagardner-nv
approved these changes
Jan 28, 2025
willkill07
approved these changes
Jan 28, 2025
|
/merge |
rapids-bot
bot
merged commit 199eae2
into
nv-morpheus:branch-25.02
15 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ProgressBarContextManager::mark_pbar_as_completed().ProgressBarContextManager::display_all()afterProgressBarContextManager::mark_pbar_as_completed(), which intermittently causes the log display issue above - which should has been fixed by this PR.Closes #2119
By Submitting this PR I confirm: