Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: C++ impl of monitor stage doesn't reset the cursor on shutdown #2119

Closed
2 tasks done
dagardner-nv opened this issue Jan 21, 2025 · 1 comment · Fixed by #2121 or #2140
Closed
2 tasks done

[BUG]: C++ impl of monitor stage doesn't reset the cursor on shutdown #2119

dagardner-nv opened this issue Jan 21, 2025 · 1 comment · Fixed by #2121 or #2140
Assignees
Labels
bug Something isn't working

Comments

@dagardner-nv
Copy link
Contributor

dagardner-nv commented Jan 21, 2025

Version

25.02

Which installation method(s) does this occur on?

Source

Describe the bug.

On shutdown of a pipeline using multiple monitor stages, the cursor will be left in the middle of the output.

This causes the shell prompt to overwrite a portion of the output, and the shell prompt might not be visible to the end-user.

Minimum reproducible example

Run the `examples/abp_pcap_detection` example as documented.

Relevant log output

Click here to see error details

====Building Segment Complete!====
Preprocessing rate[ # ] 537241 messages in 00m:09s, Throughput: 59693.44 messages/s
(morpheus) dagardner@roci:~/work/morpheus$ m:09s, Throughput: 59693.44 inf/s
Add classification rate[ # ] 537241 add-class in 00m:09s, Throughput: 59693.44 add-class/s
Serialize rate[ # ] 537241 ser in 00m:09s, Throughput: 59693.44 ser/s
Write to file rate[ # ] 537241 to-file in 00m:09s, Throughput: 59693.44 to-file/s
====Pipeline Complete====

Full env printout

Click here to see environment details

[Paste the results of print_env.sh here, it will be hidden by default]

Other/Misc.

No response

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the bug Something isn't working label Jan 21, 2025
@dagardner-nv dagardner-nv self-assigned this Jan 21, 2025
@morpheus-bot-test morpheus-bot-test bot moved this from Todo to Review - Ready for Review in Morpheus Boards Jan 21, 2025
@rapids-bot rapids-bot bot closed this as completed in c6cfa0a Jan 22, 2025
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards Jan 22, 2025
@dagardner-nv dagardner-nv reopened this Jan 27, 2025
@github-project-automation github-project-automation bot moved this from Done to In Progress in Morpheus Boards Jan 27, 2025
@dagardner-nv
Copy link
Contributor Author

I'm seeing this popup again even with the changes from #2121 which simply made this bug less likely to happen.

@morpheus-bot-test morpheus-bot-test bot moved this from In Progress to Review - Ready for Review in Morpheus Boards Jan 28, 2025
rapids-bot bot pushed a commit that referenced this issue Jan 28, 2025
… function calls (#2140)

<img width="532" alt="image" src="https://github.com/user-attachments/assets/39f491c6-4551-44a1-94a9-d3f420cf78e1" />

- [#2121](#2121) ensures the cursor is reset to the last line of output after shutdown by adding `ProgressBarContextManager::mark_pbar_as_completed()`. 
- When executing some of the pipelines, race conditions may cause calling `ProgressBarContextManager::display_all()` after `ProgressBarContextManager::mark_pbar_as_completed()`, which intermittently causes the log display issue above - which should has been fixed by this PR.

Closes #2119 

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Yuchen Zhang (https://github.com/yczhang-nv)
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)
  - Will Killian (https://github.com/willkill07)

URL: #2140
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
2 participants