-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: C++ impl of monitor stage doesn't reset the cursor on shutdown #2119
Closed
2 tasks done
Labels
bug
Something isn't working
Comments
I'm seeing this popup again even with the changes from #2121 which simply made this bug less likely to happen. |
rapids-bot bot
pushed a commit
that referenced
this issue
Jan 28, 2025
… function calls (#2140) <img width="532" alt="image" src="https://github.com/user-attachments/assets/39f491c6-4551-44a1-94a9-d3f420cf78e1" /> - [#2121](#2121) ensures the cursor is reset to the last line of output after shutdown by adding `ProgressBarContextManager::mark_pbar_as_completed()`. - When executing some of the pipelines, race conditions may cause calling `ProgressBarContextManager::display_all()` after `ProgressBarContextManager::mark_pbar_as_completed()`, which intermittently causes the log display issue above - which should has been fixed by this PR. Closes #2119 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Yuchen Zhang (https://github.com/yczhang-nv) - David Gardner (https://github.com/dagardner-nv) Approvers: - David Gardner (https://github.com/dagardner-nv) - Will Killian (https://github.com/willkill07) URL: #2140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
25.02
Which installation method(s) does this occur on?
Source
Describe the bug.
On shutdown of a pipeline using multiple monitor stages, the cursor will be left in the middle of the output.
This causes the shell prompt to overwrite a portion of the output, and the shell prompt might not be visible to the end-user.
Minimum reproducible example
Run the `examples/abp_pcap_detection` example as documented.
Relevant log output
Click here to see error details
Full env printout
Click here to see environment details
Other/Misc.
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: