Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TurtleVisualizer silently fails on out-of-range data #76

Closed
gwhitney opened this issue Dec 20, 2021 · 5 comments
Closed

TurtleVisualizer silently fails on out-of-range data #76

gwhitney opened this issue Dec 20, 2021 · 5 comments
Labels
future Not being actively worked on, but might be worked on in the future visualizer Has to do with a visualizer or the visualizer subsystem.

Comments

@gwhitney
Copy link
Collaborator

To reproduce: Start Numberscope, select Random sequence with default parameters, select Turtle Graphics with default parameters, and Create Bundle. Nothing is drawn and no feedback is provided.

@gwhitney gwhitney added the bug label Dec 20, 2021
@liammulh liammulh added the future Not being actively worked on, but might be worked on in the future label Jun 7, 2022
@liammulh
Copy link
Member

liammulh commented Nov 3, 2022

Related to #63.

@liammulh
Copy link
Member

liammulh commented Nov 7, 2022

@gwhitney, I can't reproduce following your steps. #185 might fix this, but I can't tell because I can't repro.

@gwhitney
Copy link
Collaborator Author

gwhitney commented Nov 7, 2022

Yeah, you might get something depending on the random numbers, but quickly it just silently stops. Turns out this (non-)behavior is exactly coded in the current Turtle, and might be moot/go away when Turtle is replaced.

@gwhitney gwhitney added the visualizer Has to do with a visualizer or the visualizer subsystem. label Apr 23, 2024
@gwhitney
Copy link
Collaborator Author

Should be addressed in the in-progress Turtle overhaul (#402). Setting milestone.

gwhitney pushed a commit that referenced this issue Oct 25, 2024
This fixes many issues with the Turtle Visualizer and implements several important new features. Here is a (probably not exhaustive) list:

* Adds "Fold rates" and "Stretch rates" parameters to allow animating the turtle instructions
* Allows all of the turtle instruction parameters to either be a single value applying to all elements of the domain or a separate value for each domain element. (Actually, it just repeats the last instruction element as many times as needed, which is occasionally useful in other ways as well.)
* Skips sequence entries not in the domain, rather than just stopping, but also checks that it is not skipping too large a percentage of entries
* Allows the drawing speed to be adjusted
* Allows the view to be panned, zoomed, and rolled
* Provides a few new (beautiful!) featured sequences
* Avoids restarting the path drawing on a resize
* Improves error checking of parameters
* Updates documentation
* Streamlines the parameter assignment scheme to minimize number of reinitializations at page load; this change improves the reliability of end-to-end tests

Resolves #76.
Resolves #223.
Resolves #412.
Resolves #453.
---------
Co-authored-by: Kate Stange <[email protected]>
Co-authored-by: Glen Whitney <[email protected]>
@gwhitney
Copy link
Collaborator Author

Resolved by #404. Closing.

gwhitney pushed a commit that referenced this issue Jan 20, 2025
This fixes many issues with the Turtle Visualizer and implements several important new features. Here is a (probably not exhaustive) list:

* Adds "Fold rates" and "Stretch rates" parameters to allow animating the turtle instructions
* Allows all of the turtle instruction parameters to either be a single value applying to all elements of the domain or a separate value for each domain element. (Actually, it just repeats the last instruction element as many times as needed, which is occasionally useful in other ways as well.)
* Skips sequence entries not in the domain, rather than just stopping, but also checks that it is not skipping too large a percentage of entries
* Allows the drawing speed to be adjusted
* Allows the view to be panned, zoomed, and rolled
* Provides a few new (beautiful!) featured sequences
* Avoids restarting the path drawing on a resize
* Improves error checking of parameters
* Updates documentation
* Streamlines the parameter assignment scheme to minimize number of reinitializations at page load; this change improves the reliability of end-to-end tests

Resolves #76.
Resolves #223.
Resolves #412.
Resolves #453.
---------
Co-authored-by: Kate Stange <[email protected]>
Co-authored-by: Glen Whitney <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future Not being actively worked on, but might be worked on in the future visualizer Has to do with a visualizer or the visualizer subsystem.
Projects
None yet
Development

No branches or pull requests

2 participants