-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turtle doesn't throw error when domain has repeats #412
Labels
Milestone
Comments
katestange
added
bug
Something isn't working
visualizer
Has to do with a visualizer or the visualizer subsystem.
labels
Aug 5, 2024
This will be part of the Turtle "overhaul" issue, which will have an alpha milestone, so adding that same milestone here. |
Merged
gwhitney
pushed a commit
that referenced
this issue
Oct 25, 2024
This fixes many issues with the Turtle Visualizer and implements several important new features. Here is a (probably not exhaustive) list: * Adds "Fold rates" and "Stretch rates" parameters to allow animating the turtle instructions * Allows all of the turtle instruction parameters to either be a single value applying to all elements of the domain or a separate value for each domain element. (Actually, it just repeats the last instruction element as many times as needed, which is occasionally useful in other ways as well.) * Skips sequence entries not in the domain, rather than just stopping, but also checks that it is not skipping too large a percentage of entries * Allows the drawing speed to be adjusted * Allows the view to be panned, zoomed, and rolled * Provides a few new (beautiful!) featured sequences * Avoids restarting the path drawing on a resize * Improves error checking of parameters * Updates documentation * Streamlines the parameter assignment scheme to minimize number of reinitializations at page load; this change improves the reliability of end-to-end tests Resolves #76. Resolves #223. Resolves #412. Resolves #453. --------- Co-authored-by: Kate Stange <[email protected]> Co-authored-by: Glen Whitney <[email protected]>
Resolved by #404. Closing. |
gwhitney
pushed a commit
that referenced
this issue
Jan 20, 2025
This fixes many issues with the Turtle Visualizer and implements several important new features. Here is a (probably not exhaustive) list: * Adds "Fold rates" and "Stretch rates" parameters to allow animating the turtle instructions * Allows all of the turtle instruction parameters to either be a single value applying to all elements of the domain or a separate value for each domain element. (Actually, it just repeats the last instruction element as many times as needed, which is occasionally useful in other ways as well.) * Skips sequence entries not in the domain, rather than just stopping, but also checks that it is not skipping too large a percentage of entries * Allows the drawing speed to be adjusted * Allows the view to be panned, zoomed, and rolled * Provides a few new (beautiful!) featured sequences * Avoids restarting the path drawing on a resize * Improves error checking of parameters * Updates documentation * Streamlines the parameter assignment scheme to minimize number of reinitializations at page load; this change improves the reliability of end-to-end tests Resolves #76. Resolves #223. Resolves #412. Resolves #453. --------- Co-authored-by: Kate Stange <[email protected]> Co-authored-by: Glen Whitney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
It should probably say something to the user when the domain has repeats.
The text was updated successfully, but these errors were encountered: