Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1769: expose pii detection in new job workflow as well as job #3353

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
allow changing source id but resets patterns
  • Loading branch information
nickzelei committed Mar 12, 2025
commit 6d375d6bc1b5b22cc9e1471be305e0710a643549
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,20 @@ export default function PiiDetectConnectionCard({
<form onSubmit={onSubmit} className="space-y-6">
<SourceConnectionId
value={formData.sourceId}
onChange={(value) => setFormData({ ...formData, sourceId: value })}
onChange={(value) =>
setFormData({
...formData,
sourceId: value,
tableScanFilter: {
...formData.tableScanFilter,
patterns: {
schemas: [],
tables: [],
},
},
})
}
error={errors['sourceId']}
isDisabled={true}
/>
<UserPrompt
value={formData.userPrompt ?? ''}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,12 @@ interface SourceConnectionIdProps {
error?: string;
value: string;
onChange(value: string): void;
isDisabled?: boolean;
}

export function SourceConnectionId(
props: SourceConnectionIdProps
): ReactElement {
const { error, value, onChange, isDisabled } = props;
const { error, value, onChange } = props;

const { account } = useAccount();
const {
Expand Down Expand Up @@ -81,7 +80,6 @@ export function SourceConnectionId(
}
onChange(value);
}}
disabled={isDisabled}
>
<SelectTrigger>
<SelectValue placeholder="Select a source connection" />
Expand Down