Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1769: expose pii detection in new job workflow as well as job #3353

Conversation

nickzelei
Copy link
Member

@nickzelei nickzelei commented Mar 12, 2025

image

Copy link

linear bot commented Mar 12, 2025

Copy link

vercel bot commented Mar 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Mar 12, 2025 10:15pm

Copy link

github-actions bot commented Mar 12, 2025

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 12, 2025, 10:16 PM

@nickzelei nickzelei added the enhancement New feature or request label Mar 12, 2025
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 25.51%. Comparing base (a998809) to head (a2c458e).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
backend/services/mgmt/v1alpha1/job-service/jobs.go 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3353      +/-   ##
==========================================
- Coverage   25.51%   25.51%   -0.01%     
==========================================
  Files         401      401              
  Lines       46905    46920      +15     
==========================================
  Hits        11970    11970              
- Misses      33772    33787      +15     
  Partials     1163     1163              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

github-actions bot commented Mar 12, 2025

Benchstat Geomean Results

1.78% sec/op, -0.02% B/op, 0.00% allocs/op

Benchstat results
                                   │ main-benchmark.txt │        branch-benchmark.txt         │
                                   │       sec/op       │    sec/op     vs base               │
CleanPostgresType-4                         42.63n ± 4%   43.17n ±  2%        ~ (p=0.058 n=6)
Runner_Single-4                             7.713µ ± 5%   7.824µ ±  1%        ~ (p=0.394 n=6)
GenerateBool-4                              11.45n ± 1%   11.50n ±  2%        ~ (p=0.457 n=6)
GenerateBusinessName-4                      285.4n ± 0%   324.2n ± 17%  +13.61% (p=0.002 n=6)
GenerateCardNumber-4                        28.41n ± 1%   28.53n ±  0%        ~ (p=0.186 n=6)
GenerateCategorical-4                       104.1n ± 2%   104.8n ±  1%        ~ (p=0.087 n=6)
GenerateCity-4                              173.7n ± 0%   179.2n ±  1%   +3.14% (p=0.002 n=6)
GenerateCountry-4                           105.2n ± 1%   106.0n ±  0%        ~ (p=0.310 n=6)
GenerateEmail-4                             1.346µ ± 0%   1.348µ ±  0%        ~ (p=0.738 n=6)
GenerateFirstName-4                         203.9n ± 0%   207.8n ±  2%   +1.91% (p=0.004 n=6)
GenerateFloat64-4                           28.73n ± 1%   29.18n ±  1%   +1.53% (p=0.002 n=6)
GenerateFullAddress-4                       1.429µ ± 3%   1.443µ ±  1%        ~ (p=0.145 n=6)
GenerateFullName-4                          1.222µ ± 1%   1.351µ ±  5%  +10.60% (p=0.002 n=6)
GenerateGender-4                            41.42n ± 0%   41.64n ±  0%   +0.52% (p=0.002 n=6)
GenerateInt64-4                             28.41n ± 2%   28.30n ±  0%        ~ (p=0.937 n=6)
GenerateInt64PhoneNumber-4                  51.46n ± 2%   51.55n ±  1%        ~ (p=0.732 n=6)
GenerateInternationalPhoneNumber-4          175.8n ± 1%   175.2n ±  1%        ~ (p=0.249 n=6)
GenerateIpAddress-4                         569.3n ± 0%   549.5n ±  1%   -3.48% (p=0.002 n=6)
GenerateLastName-4                          187.4n ± 1%   193.9n ±  2%   +3.47% (p=0.002 n=6)
GenerateRandomString-4                      985.6n ± 1%   989.1n ±  2%        ~ (p=0.485 n=6)
GenerateSHA256Hash-4                        1.016µ ± 0%   1.025µ ±  0%   +0.84% (p=0.002 n=6)
GenerateSSN-4                               305.8n ± 1%   302.4n ±  0%   -1.10% (p=0.002 n=6)
GenerateState-4                             105.2n ± 2%   105.6n ±  0%        ~ (p=0.255 n=6)
GenerateStreetAddress-4                     204.0n ± 1%   216.0n ±  0%   +5.93% (p=0.002 n=6)
GenerateStringPhoneNumber-4                 179.3n ± 0%   178.8n ±  1%        ~ (p=0.169 n=6)
GenerateUnixTimestamp-4                     77.13n ± 1%   77.61n ±  0%   +0.63% (p=0.026 n=6)
GenerateUsername-4                          351.5n ± 0%   380.3n ±  7%   +8.22% (p=0.002 n=6)
GenerateUTCTimestamp-4                      104.2n ± 1%   104.5n ±  1%        ~ (p=0.210 n=6)
GenerateUUID-4                              734.0n ± 0%   744.5n ±  0%   +1.42% (p=0.002 n=6)
GenerateZipcode-4                           105.2n ± 2%   106.3n ±  0%        ~ (p=0.061 n=6)
TransformCharacterScramble-4                171.8n ± 1%   172.3n ±  1%        ~ (p=0.327 n=6)
TransformE164PhoneNumber-4                  180.2n ± 3%   183.3n ±  0%        ~ (p=0.065 n=6)
TransformEmail-4                            1.798µ ± 2%   1.801µ ±  1%        ~ (p=0.509 n=6)
TransformFirstName-4                        233.9n ± 0%   240.1n ±  1%   +2.65% (p=0.002 n=6)
TransformFloat64-4                          110.8n ± 4%   116.1n ±  0%   +4.78% (p=0.002 n=6)
TransformFullName-4                         1.235µ ± 2%   1.323µ ±  4%   +7.13% (p=0.002 n=6)
TransformInt64-4                            33.74n ± 1%   33.63n ±  0%        ~ (p=0.589 n=6)
TransformInt64PhoneNumber-4                 57.84n ± 2%   58.02n ±  1%        ~ (p=0.065 n=6)
TransformLastName-4                         191.6n ± 0%   200.9n ±  4%   +4.88% (p=0.002 n=6)
TransformString-4                           1.022µ ± 0%   1.027µ ±  1%   +0.39% (p=0.015 n=6)
TransformStringPhoneNumber-4                211.0n ± 2%   210.2n ±  0%   -0.36% (p=0.026 n=6)
TransformUuid-4                             36.54n ± 1%   36.75n ±  0%   +0.57% (p=0.011 n=6)
geomean                                     194.0n        197.5n         +1.78%

                                   │ main-benchmark.txt │         branch-benchmark.txt         │
                                   │        B/op        │     B/op      vs base                │
CleanPostgresType-4                        0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                          2.312Ki ± 1%     2.297Ki ± 4%       ~ (p=0.180 n=6)
GenerateBool-4                             0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     304.0 ± 0%       304.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      64.00 ± 0%       64.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                             160.0 ± 0%       160.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                            385.0 ± 0%       385.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        208.0 ± 0%       208.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      512.0 ± 0%       512.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                         418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                           16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                            7.000 ± 0%       7.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        31.00 ± 0%       31.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                         176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     186.0 ± 0%       186.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       288.0 ± 0%       288.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                              46.00 ± 0%       46.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateState-4                            24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    240.0 ± 0%       240.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                         205.0 ± 0%       205.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                             80.00 ± 0%       80.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               40.00 ± 3%       40.00 ± 3%       ~ (p=1.000 n=6)
TransformE164PhoneNumber-4                 40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                           489.0 ± 0%       489.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                       224.0 ± 0%       224.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                         88.00 ± 0%       88.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                        418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                           8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                        176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformString-4                          202.0 ± 0%       202.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               56.00 ± 0%       56.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                            16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                               ²                 -0.02%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                   │ main-benchmark.txt │        branch-benchmark.txt        │
                                   │     allocs/op      │ allocs/op   vs base                │
CleanPostgresType-4                        0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                            24.00 ± 0%     24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBool-4                             0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                             2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                          2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                            8.000 ± 0%     8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      10.00 ± 0%     10.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                         6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                           1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                            0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                         2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       7.000 ± 0%     7.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                              3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateState-4                            2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                         6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                             3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformE164PhoneNumber-4                 3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                           14.00 ± 0%     14.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                       3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                         3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                        6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                           1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformString-4                          4.000 ± 0%     4.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               4.000 ± 0%     4.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                            1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                               ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

@nickzelei nickzelei merged commit f8737e5 into main Mar 12, 2025
24 of 26 checks passed
@nickzelei nickzelei deleted the nick/neos-1769-expose-pii-detection-in-new-job-workflow-as-well-as-job-id branch March 12, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants