Add What's new modal #372
Add What's new modal #372
Conversation
There was a problem hiding this comment.
Thanks for the PR, I recently thought it would be nice to have some kind of update notification in the client.
I guess we can live with english only and messed up markdown for now (open issue?). Don't know if it would be an alternative to use a proper markdown to HTML renderer and in the client search for the version and split the HTML there ourselves.
But I do hate sites that shove a popup in my face when entering, no matter for what reason. So, could you please change this to something less obstrusive, e.g.
- expand Message class with a
showInfotype to show a short message and a link to open the modal. Such a message doesn't get in the way and does not require interaction as it disappears with the next route request - link the version in the Navbar to open the modal and add some "new" badge and highlight
bagage
force-pushed
the
feat/whatsnew
branch
from
6255eb7 to
fb236bb
Compare
|
I modified the PR according to your feedback @nrenner, thanks! One thing I did not do is having a link directly from navbar to Whatsnew modal: when you click on the version, it opens the About modal yet (from which you can go to What's new modal). I wasn't sure about how to do that cleanly and comprehensible by users, so I left it as is. Feel free to modify it if you have an idea for that! |
bagage
force-pushed
the
feat/whatsnew
branch
from
fb236bb to
d064e14
Compare
|
That's fine, it was more like an either/or suggestion. Thanks! |
* upstream/master: Update France Go area to 10km Update bootstrap-select dep to avoid error on mobile Improve modal dialogs consistency Rename dialog Make modals fullscreen on mobile Hide expand icon on moblie (nrenner#296) Gray out unselectable layers (nrenner#381) Update translations Translate overlay type and fix width computation (nrenner#379) Use plural form when multiple overlays are active (nrenner#378) Add message if no elevation data is available (nrenner#373) Add missing translatable content (nrenner#376) Remove debug code Update translations Add What's new modal (nrenner#372) Add Babel and core-js & regenerator polyfills (nrenner#367)
This PR adds a new modal that is displayed to users when they come from an earlier version (that information being stored in localStorage).
What's new?modal is also always accessible inAboutmodal, to see the whole history.For instance assuming I previously was on 0.13.1, on next launch I will see:
There are some facts I'm not totally happy with:
Anyway any feedbacks are welcome as always :).