Support ES6+ using Babel #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefankeidel
added a commit
to cxberlin/brouter-web
that referenced
this pull request
Apr 8, 2021
* upstream/master: Update France Go area to 10km Update bootstrap-select dep to avoid error on mobile Improve modal dialogs consistency Rename dialog Make modals fullscreen on mobile Hide expand icon on moblie (nrenner#296) Gray out unselectable layers (nrenner#381) Update translations Translate overlay type and fix width computation (nrenner#379) Use plural form when multiple overlays are active (nrenner#378) Add message if no elevation data is available (nrenner#373) Add missing translatable content (nrenner#376) Remove debug code Update translations Add What's new modal (nrenner#372) Add Babel and core-js & regenerator polyfills (nrenner#367)
nrenner
added a commit
that referenced
this pull request
May 8, 2023
Removed in #367, but core-js does not include fetch, and eslint-plugin-compat just doesn't seem to complain when inside an if block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #249
For now, runs Babel with Gulp and loads full core-js-bundle and regenerator-runtime polyfills with script tags.
Keeps eslint-plugin-compat, might still be useful to warn about features that are not transpiled nor polyfilled, but I'm not sure about that.