Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

Release 0.5.2 #81

Merged
merged 57 commits into from
Feb 13, 2018
Merged

Release 0.5.2 #81

merged 57 commits into from
Feb 13, 2018

Conversation

tobiasheine
Copy link
Contributor

Description

This PR prepares the release 0.5.2 of the plugin wich adds the support for filtering for variants for Android Lint. Besides that it also contains the changes from develop regarding the release to the Gradle Plugins Repository.

Considerations

  • bumped version to 0.5.2
  • modified changelog and readme

tobiasheine and others added 30 commits February 2, 2018 14:59
@tobiasheine
Add gradle plugin repo publishing dependency
9a91267
@tobiasheine
Configure gradle plugin repo publishing plugin
39825ca
@tobiasheine
Update readme to include the gradle plugin repo support
f7ee48a
@tobiasheine
Update readme to mention kotlin projects
aaf1e20
@rock3r
Merge pull request #72 from novoda/master
d4d624b 
Back merge master
@tobiasheine
Update gradle plugin repo description
2795182
@tobiasheine
Update dependency name
3ca1071
@tobiasheine
Publish plugin to the Gradle plugins repo as part of the publishRelea…
56db796 
…se task
@tobiasheine
Fix typo
89b7bc3
@tobiasheine
Merge branch 'develop' into PT-508/prepare_gradle_repo_release
7af0a91
@tobiasheine
Use single quotes
994c08d
@tobiasheine
Extract common strings
8ee4003
@tobiasheine
Bring back version and highlight that just one option to apply is needed
384f2e2
@tobiasheine
Remove redundant gradle and plugin from the id being used for the gra…
8578176 
…dle plugin repo
@tobiasheine
Remove according to the documentation not needed group
9d46087
@tobiasheine
Inline not needed variables
06d0af0
@tobiasheine
Use gradlePluginPortal which is available in gradle 4.4.1
b977c29
@tobiasheine
Use gradle wrapper to increase the version
4421b19
@mr-archano
Update wrapper task to target Gradle version and distributiontype we …
1e81e16 
…want
@mr-archano
Merge pull request #73 from novoda/PT-508/prepare_gradle_repo_release
c1e5f3d 
[PT-508]: Prepare gradle plugin repo release
@tobiasheine
Add skeleton task to prepare the gradle plugins repo release
df4a2fc
@tobiasheine
Load gradle plugin repo credentials from secrets.properties if available
b341bf8
@tobiasheine
Add hint to add the gradle plugins repo credentials to the secrets.pr…
63c7a28 
…operties
@tobiasheine
Prepare gradle plugins repo release as part of general preparation task
8174f6c
@tobiasheine
Resolve properties using rootProject
fa45e1a
@tobiasheine
Use correct api to check whether properties exist
27da0f5
@tobiasheine
Fix typo
b64d4e2
@tobiasheine
Use the build properties plugin to validate credentials
f559d10
@tobiasheine
Remove group and description from task since it shouldn't be run manu…
bbf9d58 
…ally from the IDE
@tasomaniac
Merge pull request #76 from novoda/PT-548/automate_release_gradle_repo
dd93ba8 
PT-548: Consume gradle plugins repo credentials from secrets.properties
Said Tahsin Dane and others added 25 commits February 8, 2018 12:56
Extract trait for VariantAware implementation
06d45ae
@tasomaniac
Merge pull request #78 from novoda/PT-563/consume_credentials_from_env
019de48 
[PT-563] Consume gradle plugins repo credentials from env
Make lint configurator variant aware and add tests for that.
b7027f0
Make the tests more clear by extracting logic
d92177f
Still have default closure to keep backward compatible but have a set…
4a8e826 
…ter to know if we have a custom filter set.

Simplify lint configurator by extracting methods
@tasomaniac
Merge branch 'develop' into android-lint-improves
e4307ae
Add a test around ignoring inactive variant
3a5b7bb
Make it simpler by removing hasFilter and make the filter nullable
83fb0a3
Have a generic type closure instead of DomainObjectSet
ccff5d2
null check instead of using old hasFilter method
a3e1b75
inline method
69efef0
Calculate the file and task name in the upper level
935adbb 
to have less logic in the task creation
Also changed html output to be the same as the xml one
Use real collaborator instead of a trait
98050dc
field needs to be protected. Weird groovy
c85f80a
Extract method again for clarity
43c8b0e
Simplify by not collecting multiple variant collections into one
cd178a3
Move afterEvaluate to the only place it is needed.
22a6411 
Extract method for clarity
Remove private since they are accessed from subclasses
26bc283
@tasomaniac
Merge pull request #79 from novoda/android-lint-improves
5c4e39b 
Android lint variant filter support
@tasomaniac
Merge branch 'develop' into clean-up
dd00475
Fix merge conflict problems
7749bf2
@tobiasheine
Merge pull request #80 from novoda/clean-up
e0d14b1 
Clean up variant aware code
@tobiasheine
Bump version to 0.5.2
41392b4
@tobiasheine
Append support for variants filtering in android lint to changelog
b638d77
@tobiasheine
Change usage to include variants filtering for android lint
b7a6917
tasomaniac
tasomaniac approved these changes Feb 13, 2018
View reviewed changes
Copy link
Contributor

@tasomaniac tasomaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from doc updates, the rest is already reviewed.

@mr-archano mr-archano merged commit 679dbc5 into master Feb 13, 2018
@mr-archano mr-archano deleted the prepare_release_0_5_2 branch February 13, 2018 17:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tasomaniac tasomaniac tasomaniac approved these changes

@mr-archano mr-archano mr-archano approved these changes

Assignees
No one assigned
Labels
release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tobiasheine @tasomaniac @mr-archano @rock3r