This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
[PT-563] Consume gradle plugins repo credentials from env #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasheine
commented
Feb 8, 2018
| System.properties['com.gradle.login.properties.file'] = rootProject.file('secrets.properties') | ||
| String key = buildProperties.env['GRADLE_PLUGINS_REPO_KEY'].or(buildProperties.secrets['gradle.publish.key']).string | ||
| String secret = buildProperties.env['GRADLE_PLUGINS_REPO_SECRET'].or(buildProperties.secrets['gradle.publish.secret']).string | ||
| project.setProperty('gradle.publish.key', key) |
There was a problem hiding this comment.
Should that be rootProject? 🤔
There was a problem hiding this comment.
I think project because we apply the publish plugin to project not root. I may be wrong :)
tasomaniac
approved these changes
Feb 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked in JIRA PT-563
Description
By having another look at the documentation I read that there is an alternative to putting the credentials to the
gradle.properties. Instead we can set these project properties-Pgradle.publish.key=<key> -Pgradle.publish.secret=<secret>.I added the credentials to Jenkins through the credentials plugin and bind them to the env variables
GRADLE_PLUGINS_REPO_KEYandGRADLE_PLUGINS_REPO_SECRET.Scope of this PR is to change
prepareGradlePluginsRepoReleaseto read these credentials from the env variables and set the project properties. As fallback for a local release we still also check thesecrets.properties.