Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: bump @google-cloud/storage to 7.x #3797

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 2, 2024

@nschonni
Copy link
Member

nschonni commented Jul 2, 2024

Any value in adding those to https://github.com/nodejs/build/blob/main/.github/dependabot.yml
I don't recall if it works without the lockfile though

@trivikr
Copy link
Member Author

trivikr commented Jul 2, 2024

Any value in adding those to main/.github/dependabot.yml

Yes. But only after deployments are automated.
Currently, I'm doing manual deployments as documented in #3779

I plan to convert the scripts to ESM, break them into modular components, add jsdoc/linter/formatter/tests etc
I plan to post PRs gradually, as existing PRs are merged.

@trivikr
Copy link
Member Author

trivikr commented Jul 3, 2024

This PR has been open for 48+ weekday hours, and is ready to merge.

@targos targos merged commit 0390c09 into nodejs:main Jul 6, 2024
1 check passed
@trivikr trivikr deleted the bump-google-cloud-storage branch July 6, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants