Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: add documentation for updating Cloud Run #3779

Merged
merged 16 commits into from
Jul 2, 2024

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 25, 2024

Fixes: #3789

Original suggestion in #3767 (comment)
It was obtained by going through the source code, and GCP documentation.

It was updated in comments which followed in the issue.
The summary is added as README files in each folder.

@trivikr trivikr marked this pull request as ready for review June 25, 2024 19:09
@trivikr trivikr force-pushed the docs-metrics branch 2 times, most recently from 6e7d999 to 50dec14 Compare June 25, 2024 19:11
@trivikr
Copy link
Member Author

trivikr commented Jun 25, 2024

cc @targos for review

@trivikr trivikr changed the title metrics: add documentation on updating GCP Cloud Run metrics: add documentation for updating Cloud Run Jun 27, 2024
@trivikr
Copy link
Member Author

trivikr commented Jun 28, 2024

Can this get some reviews?

It documents the existing setup, the process to be followed for updating Cloud Run.
And also switches to using Application Default Credentials (ADC) instead of reading them from a file.

Since the region is generic, and can be set as default in gcloud CLI
@trivikr
Copy link
Member Author

trivikr commented Jul 2, 2024

This PR is ready for merge.

I forgot to copy metrics-processor-service-key.json while deploying some other updates, and had to fix them.

After this is merged, we no longer have to copy metrics-processor-service-key.json, and the deploy instructions will be available in README for anyone to refer to.

@targos targos merged commit 19556d2 into nodejs:main Jul 2, 2024
1 check passed
@trivikr trivikr deleted the docs-metrics branch July 2, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metrics: use Application Default Credentials (ADC) with attached service account for Cloud Run
2 participants