Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new parameter "--kexec-extra-flags" #332

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

johbo
Copy link
Contributor

@johbo johbo commented Jun 7, 2024

This allows to pass in special flags like "--no-sync" into the call to "kexec".

This does depend on a PR to nixos-images:

@Mic92
Copy link
Member

Mic92 commented Jun 10, 2024

--kexec-extra-flags has been merged now.

@Mic92
Copy link
Member

Mic92 commented Jun 10, 2024

Can you do an nix-flake update, so we actually use the new code in the test?

@johbo
Copy link
Contributor Author

johbo commented Jun 10, 2024

Can you do an nix-flake update, so we actually use the new code in the test?

Did the update, not fully sure about it though. I've in a first commit only done the nixos-images which also did apply a change caused probably by an older refactoring, a rename from nixos-2311 to nixos-stable ?

Added a second commit which updates all dependencies. I am not sure which flow prefer, e.g. update them all vs. just update the minimal set in this PR. 😬

This allows to pass in special flags like "--no-sync" into the call to "kexec".
@johbo
Copy link
Contributor Author

johbo commented Jun 10, 2024

Oh wait, I missed a rebase, will update one more time ⏲️

johbo added 2 commits June 10, 2024 11:51
Flake lock file updates:

• Updated input 'nixos-images':
    'github:nix-community/nixos-images/f267906ba610b2e29f3f45ab45a0669e28c407ef?narHash=sha256-tb5aB7YSZUXl0OHKLXZJNJgRtnyxlgtabvj3xGsShMU%3D' (2024-06-07)
  → 'github:nix-community/nixos-images/e2fd329c3a39a90bb43e1e2cf47c180ed57831bf?narHash=sha256-ueTu01bYU5QXdL77psMkApYHpk339xNHg/M7ZzP3uPI%3D' (2024-06-10)
Flake lock file updates:

• Updated input 'disko':
    'github:nix-community/disko/713aa3df481782719aed4d8c20ad31a9effe3564?narHash=sha256-geTO9YL1V9zYGxupuZvKFWxh6II9sH2bjI1dmEVhVYQ%3D' (2024-06-06)
  → 'github:nix-community/disko/c1cfbfad7cb45f0c177b35b59ba67d1b5fc7ca82?narHash=sha256-nlh/2uD5p2SAdkn6Zuey20yaR5FFWvhL3poapDGNE4Y%3D' (2024-06-10)
• Updated input 'nixos-stable':
    'github:NixOS/nixpkgs/0b8e7a1ae5a94da2e1ee3f3030a32020f6254105?narHash=sha256-WZ1s48OODmRJ3DHC%2BI/DtM3tDRuRJlNqMvxvAPTD7ec%3D' (2024-06-05)
  → 'github:NixOS/nixpkgs/9b5328b7f761a7bbdc0e332ac4cf076a3eedb89b?narHash=sha256-1%2Bua0ggXlYYPLTmMl3YeYYsBXDSCqT%2BGw3u6l4gvMhA%3D' (2024-06-06)
• Updated input 'nixpkgs':
    'github:nixos/nixpkgs/bf3faad723ca984fc4ea95c1cee1d975a8ca2a28?narHash=sha256-hqHp0W7ibfdu5DFc6EG3S3c%2BGSAbti7VUldFXSf/WiI%3D' (2024-06-07)
  → 'github:nixos/nixpkgs/7d916e720af6b2ca355e4d0cfb8e4f742c172239?narHash=sha256-THcv8qDqobZefHHluPjx/8n%2BMtVVb8ag/oJbKMqKNRo%3D' (2024-06-09)
• Updated input 'treefmt-nix':
    'github:numtide/treefmt-nix/3eb96ca1ae9edf792a8e0963cc92fddfa5a87706?narHash=sha256-u10aDdYrpiGOLoxzY/mJ9llST9yO8Q7K/UlROoNxzDw%3D' (2024-06-01)
  → 'github:numtide/treefmt-nix/4fc1c45a5f50169f9f29f6a98a438fb910b834ed?narHash=sha256-npYqVg%2BWk4oxnWrnVG7416fpfrlRhp/lQ6wQ4DHI8YE%3D' (2024-06-08)
@johbo
Copy link
Contributor Author

johbo commented Jun 10, 2024

Now it also did the update in a cleaner way. 🎉

@Mic92
Copy link
Member

Mic92 commented Jun 10, 2024

@mergify queue

Copy link
Contributor

mergify bot commented Jun 10, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 46dc28f

@mergify mergify bot merged commit 46dc28f into nix-community:main Jun 10, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants