Use writeShellApplication for packaging

[Kranzes]

With this change the packaging will be made with writeShellApplication which allows adding runtime inputs (deps) to the script by setting the $PATH variable at the top of the file. It also has a check phase which tests the shell file against shellcheck like we did before manually. It also sets the safety bash options.

you can read more about writeShellApplication here -> https://github.com/NixOS/nixpkgs/blob/d3a307c813cbd209fe1e13ac9246b3fa3ea93c12/pkgs/build-support/trivial-builders.nix#L282

[Kranzes]

I have a fork/branch for with some more improvements (& that utilizes of flake.parts), is that something you are interested in me PR'ing over?

[Mic92]

bors merge

[bors]

Build succeeded:

• check from-nixos-with-sudo [x86_64-linux]
• check from-nixos [x86_64-linux]
• deploy
• Evaluate flake.nix
• package default [x86_64-linux]
• package docs [x86_64-linux]
• package nixos-remote [x86_64-linux]

[Mic92]

I have a fork/branch for with some more improvements (& that utilizes of flake.parts), is that something you are interested in me PR'ing over?

Yes. Looks useful: https://github.com/Kranzes/nixos-remote/commit/b400913411bf42a49479abd50c583935f704a0cb

[Mic92]

But maybe keep the packages with importable with callPackage. I think some folks still want to manually import them without using flakes.

[Kranzes]

But maybe keep the packages with importable with callPackage. I think some folks still want to manually import them without using flakes.

what about using builtins.getFlake? I am also not exactly sure what you are referring to but let me create a PR and you will add the suggestions.

Oh I get what you mean, but also I'm not sure that "some people don't use flakes" argument holds much considering basically all of this project depends on flakes. From the shell script (nixos-remote), disko and more.

[Kranzes]

I have a fork/branch for with some more improvements (& that utilizes of flake.parts), is that something you are interested in me PR'ing over?

Yes. Looks useful: Kranzes@b400913

I created the PR: #23

[Mic92]

nixos-remote can be still used without flakes. All parameter have fallbacks for store paths. It's mainly checks where also import flakes.