fix nil node in sym ast of exported ref objects [backport:2.2] #24527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes nim-lang#24526, follows up nim-lang#23101
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
narimiran
pushed a commit
that referenced
this pull request
Jan 14, 2025
fixes #24526, follows up #23101 The `shallowCopy` calls do not keep the original node's children, they just make a new seq with the same length, so the `Ident "*"` node from the original postfix nodes was not carried over, making it `nil` and causing the segfault. (cherry picked from commit b529f69)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #24526, follows up #23101
The
shallowCopycalls do not keep the original node's children, they just make a new seq with the same length, so theIdent "*"node from the original postfix nodes was not carried over, making itniland causing the segfault.