Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retain postfix node in type section typed AST, with docgen fix #23101

Merged
merged 7 commits into from
Dec 23, 2023
Merged

retain postfix node in type section typed AST, with docgen fix #23101

merged 7 commits into from
Dec 23, 2023

Conversation

metagn
Copy link
Collaborator

@metagn metagn commented Dec 19, 2023 •
edited
Loading

Continued from #23096 which was reverted due to breaking a package and failing docgen tests. Docgen should now work, but a PR is still pending for the package: SciNim/Unchained#45 has been merged

@metagn metagn closed this Dec 20, 2023
@metagn metagn reopened this Dec 20, 2023
@metagn metagn closed this Dec 20, 2023
@metagn metagn reopened this Dec 20, 2023
@metagn metagn force-pushed the type-section-postfix branch from 6ac6c85 to 72b480f Compare December 20, 2023 23:14
@metagn
Copy link
Collaborator Author

metagn commented Dec 21, 2023

CI now passes

@Araq
Copy link
Member

Araq commented Dec 22, 2023 •
edited
Loading

Superb work, but how hard would it be for the doc gen to not render the export markers? Only public symbols are visible in the docs anyway so the export marker is redundant and it's bit uglier with them.

@metagn
Copy link
Collaborator Author

metagn commented Dec 22, 2023 •
edited
Loading

Apparently the docgen just renders the AST, we could add a TRenderFlag that never renders postfixes. This would also make object fields not render postfixes anymore (right now they do). Edit: Added renderNoPostfix, but it has an exception for fields

That being said I only now realized let/const/proc also do not retain postfix nodes. I can do these as well but they have a chance of breaking packages again (especially proc), should they go in a separate PR after this one?

@Araq
Copy link
Member

Araq commented Dec 23, 2023

should they go in a separate PR after this one?

Yes, please.

@Araq Araq merged commit c0acf3c into nim-lang:devel Dec 23, 2023
17 of 19 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from c0acf3c

Hint: mm: orc; opt: speed; options: -d:release
177542 lines; 7.825s; 768.309MiB peakmem

metagn added a commit to metagn/Nim that referenced this pull request Dec 23, 2023
@metagn
retain postfix node for typed variable/routine AST; save field syms
a15c2f0 
refs nim-lang#23101
@metagn metagn mentioned this pull request Dec 23, 2023
Open
metagn added a commit to metagn/Nim that referenced this pull request Jun 23, 2024
@metagn
retain postfix node for typed variable/routine AST; save field syms
9a301db 
refs nim-lang#23101
metagn added a commit to metagn/Nim that referenced this pull request Aug 17, 2024
@metagn
retain postfix node for typed variable/routine AST; save field syms
606f841 
refs nim-lang#23101
metagn added a commit to metagn/Nim that referenced this pull request Oct 14, 2024
@metagn
retain postfix node for typed variable/routine AST; save field syms
ffe5335 
refs nim-lang#23101
@metagn metagn mentioned this pull request Dec 10, 2024
Closed
metagn added a commit to metagn/Nim that referenced this pull request Dec 10, 2024
@metagn
fix nil node in sym ast of exported ref objects
42982b7 
fixes nim-lang#24526, follows up nim-lang#23101
@metagn metagn mentioned this pull request Dec 10, 2024
Merged
Araq pushed a commit that referenced this pull request Dec 10, 2024
@metagn
fix nil node in sym ast of exported ref objects [backport:2.2] (#24527)
b529f69 
fixes #24526, follows up #23101

The `shallowCopy` calls do not keep the original node's children, they
just make a new seq with the same length, so the `Ident "*"` node from
the original postfix nodes was not carried over, making it `nil` and
causing the segfault.
narimiran pushed a commit that referenced this pull request Jan 14, 2025
@metagn @narimiran
fix nil node in sym ast of exported ref objects [backport:2.2] (#24527)
4e1bc42 
fixes #24526, follows up #23101

The `shallowCopy` calls do not keep the original node's children, they
just make a new seq with the same length, so the `Ident "*"` node from
the original postfix nodes was not carried over, making it `nil` and
causing the segfault.

(cherry picked from commit b529f69)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metagn @Araq