Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix #19600 No error checking on fclose (#19836)" #20297

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented Sep 2, 2022

This reverts commit 04e4a5e.

The PR doesn't pass CI when it was merged. It passes later because all platforms are disabled in #20287

2022-08-29T16:29:58.5667562Z �[31mFAIL: �[36mtests/misc/t19600.nim c                                     �[34m ( 1.08 sec)�[0m
2022-08-29T16:29:58.5668370Z �[1m�[36mTest "tests/misc/t19600.nim" in category "misc"�[0m
2022-08-29T16:29:58.5669082Z �[1m�[31mFailure: reExitcodesDiffer�[0m
2022-08-29T16:29:58.5669720Z �[33mExpected:�[0m
2022-08-29T16:29:58.5670316Z �[1mexitcode: 1
2022-08-29T16:29:58.5670857Z �[0m
2022-08-29T16:29:58.5671423Z �[33mGotten:�[0m
2022-08-29T16:29:58.5672018Z �[1mexitcode: 0
2022-08-29T16:29:58.5672327Z 
2022-08-29T16:29:58.5672734Z Output:
2022-08-29T16:29:58.5673008Z 
2022-08-29T16:29:58.5673503Z �[0m

ref https://github.com/nim-lang/Nim/runs/8076466640

@ringabout ringabout requested review from Varriount and Araq September 2, 2022 02:26
@Araq Araq merged commit 5ff06fd into devel Sep 2, 2022
@Araq Araq deleted the pr_revert_19836 branch September 2, 2022 17:04
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 5ff06fd

Hint: mm: orc; threads: on; opt: speed; options: -d:release
163962 lines; 13.564s; 842.188MiB peakmem

capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants