fixes the regressions caused by the fix for #20107 [backport] #20287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tersec
reviewed
Aug 30, 2022
tests/ccgbugs/tderefblock.nim
Outdated
| @@ -1,5 +1,5 @@ | |||
| discard """ | |||
| cmd: "nim c -d:release -d:danger $file" | |||
| cmd: "nim c -d:release -d:danger --gc:orc $file" | |||
There was a problem hiding this comment.
Would it be reasonable to test both ORC and non-ORC? There appeared to be at least somewhat distinct failure modes, and therefore, conversely, it's not obvious that ORC might not work with non-ORC failing.
|
Thanks for your hard work on this PR! Hint: mm: orc; threads: on; opt: speed; options: -d:release |
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
…nim-lang#20287) * fixes the regressions caused by the fix for nim-lang#20107 [backport]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.