Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix libssl order. Newest one is 1.1 #10236

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Conversation

treeform
Copy link
Contributor

@treeform treeform commented Jan 8, 2019

From comment by @alaviss #10230 (comment)

@Araq Araq added the merge_when_passes_CI mergeable once green label Jan 8, 2019
@cheatfate
Copy link
Member

I think this is annoying to patch stdlib all the time ssl libraries release new version.

@treeform
Copy link
Contributor Author

treeform commented Jan 8, 2019

For me the ssl libraries have been the most annoying libraries.

@dom96
Copy link
Contributor

dom96 commented Jan 8, 2019

I think this is annoying to patch stdlib all the time ssl libraries release new version.

I agree, can't we just allow anything between the libssl and .so?

@treeform
Copy link
Contributor Author

treeform commented Jan 8, 2019

Then it would select a random libssl, probably an older version and break stuff. This patch tries to make it be smart to pick the newest one you have installed.

@treeform
Copy link
Contributor Author

treeform commented Jan 8, 2019

Oh and it does pick libssl.so with no version last. So if you don't have a matching version you can get it to work by removing the version part out of your libssl****.so file.

@genotrance genotrance merged commit def477a into nim-lang:devel Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants