Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the search order of libSSL libs from newest to oldest. #10230

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

treeform
Copy link
Contributor

@treeform treeform commented Jan 7, 2019

fixes #9419

It currently searches for libSSL versions in random order:
.1.1|.38|.39|.41|.43|.44|.45|.46|.10|.1.0.2|.1.0.1|.1.0.0|.0.9.9|.0.9.8|
Its a mystery which one it will pick up. Newest version 1.0.2 is some where in the middle, so its highly likely it will not pick it up.

A better system is to search in order of new -> old:
.1.0.2|.1.0.1|.1.0.0|.0.9.9|.0.9.8|.1.1|.38|.39|.41|.43|.44|.45|.46|.10

@krux02 krux02 merged commit 3ed8331 into nim-lang:devel Jan 8, 2019
@alaviss
Copy link
Collaborator

alaviss commented Jan 8, 2019

Actually, 1.1 is the latest version of openssl. The .xx are libressl versions. I think you should update openssl.nim to prefer 1.0 branch over 1.1 if openssl10 is defined.

A side effect of this PR is that if anyone have both openssl 1.0 and 1.1 installed and they use symbols that only exists in openssl 1.1 their program will stop executing.

## If you want to statically link against OpenSSL 1.0.x, you now have to
## define the ``openssl10`` symbol via ``-d:openssl10``.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

httpclient -d:ssl and db_postgres incompatible and cause SIGSEGV! (MacOSX)
3 participants