-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for setting of BG Targets #321
Conversation
Signed-off-by: Sjoerd-Bo3 <[email protected]>
Signed-off-by: Sjoerd-Bo3 <[email protected]>
Signed-off-by: Sjoerd-Bo3 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on testing with GH build.
Edit: Did check that there are no uncommitted changes after the build. But did not do significant code review.
Tested successfully setting mmol target values of:
4 (min)
4,1
6
6,1
6,2
10 (max)
Also tested with mg/dL units:
72 (min)
109
110
111
180 (max)
SummaryI confirm Issue #318 is fixed with this patch TestingTested by applying patch to alpha commit 82f2d01
|
Bandaid fix for now, we generally a more thought out handling of mmol values; handle everything in mg/dl and only display in mmol. This fixes #318 and LGTM. Merging with 3 approvals. |
…argets Fix for setting of BG Targets
Implemented the iAPS fix https://github.com/Artificial-Pancreas/iAPS/pull/715/files that closes Issue #318