Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set a BG target of 6.1, silent reset to 4 mmol/l #318

Closed
widmann opened this issue Jun 17, 2024 · 4 comments · Fixed by #321
Closed

Cannot set a BG target of 6.1, silent reset to 4 mmol/l #318

widmann opened this issue Jun 17, 2024 · 4 comments · Fixed by #321

Comments

@widmann
Copy link

widmann commented Jun 17, 2024

Trio is also affected by this bug:
Artificial-Pancreas/iAPS#712

If I try to set a BG target of 6.1 mmol/l in the UI, the setting is silently reset to 4 mmol/l after saving and exiting the UI. Setting 6.0 or 6.2 mmol/l works, so there is a workaround. However, since there is no visual feedback of the reset and a target of 4 mmol/l could have serious side effects, I would consider this a high priority issue.

Steps to reproduce:

  • Open the target BG UI.
  • Set a target of 6.1 mmol/l.
  • Press save.
  • Go back to Settings.
  • Re-enter the target BG UI and find the target set to 4 mmol/l.

Expected result:

  • BG target set to 6.1 mmol/l.

Actual result:

  • BG target set to 4 mmol/l.

A prerequisite is probably setting the BG units to mmol/l, but I have not systematically tested this yet.

@marionbarker
Copy link
Contributor

Summary

I confirm this issue exists with the most recent configuration for Trio-alpha.

Testing

  • updated the latest alpha branch, commit 82f2d01
  • built on existing Trio, SE running iOS 17.5.1
  • set units to mmol/L
    • target was 99 mg/dL, now 5.5 mmol/L
    • modify target, save, go to settings, return to target screen:
      • choose 6.0; final 6.0
      • choose 6.1; final 4.0
      • choose 6.2; final 6.2

@Sjoerd-Bo3
Copy link
Contributor

Did the same testing as Marion with the same outcome.

@Sjoerd-Bo3 Sjoerd-Bo3 added this to the Trio 1.0 release milestone Jun 17, 2024
@bjornoleh
Copy link
Contributor

Can confirm this was the same with an older iAPS build (v2.2.5)

@dsut4392
Copy link

Yep, confirmed same in dev32b5e95 with pump simulator.

@Sjoerd-Bo3 Sjoerd-Bo3 linked a pull request Jun 18, 2024 that will close this issue
@dnzxy dnzxy closed this as completed Jun 19, 2024
@github-project-automation github-project-automation bot moved this to Done in Trio Jun 19, 2024
mountrcg pushed a commit to mountrcg/Trio that referenced this issue Aug 1, 2024
Trying latest Xcode version
@Sjoerd-Bo3 Sjoerd-Bo3 removed the bug label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants