-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix oversized inline SVGs when css is disabled #761
Conversation
…s when CSS is disabled / broken
…us sizes when CSS is disabled / broken
This looks good to me, we just need to update the HTML markup in the individual component We're planning on moving the HTML markup out of the Also I think we might need to update the SVG asset files incase anyone uses them for includes found in the |
@chrimesdev For the heights/widths inside the SVG files themselves - some of the SVGs are used in multiple places with different dimensions, so it's not possible for me to set the "correct" dimensions in each file for every case. I have therefore defaulted the SVG files to 34px x 34px which is the same as the default |
@chrimesdev I have addressed your comments and this one is ready for review again. Cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks @andymantell
Description
Add width, height, stroke and fill attributes to inline SVGs in order that they render at appropriate sizes when viewed with disabled/broken/missing CSS
Fixes #747
Checklist