Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider the appearance of components when CSS is not loaded #747

Closed
andymantell opened this issue Jun 15, 2021 · 0 comments · Fixed by #761
Closed

Consider the appearance of components when CSS is not loaded #747

andymantell opened this issue Jun 15, 2021 · 0 comments · Fixed by #761

Comments

@andymantell
Copy link
Contributor

andymantell commented Jun 15, 2021

Bug Report

What is the issue?

When viewing an nhsuk-frontend based site without CSS there are some aspects that become very large (the back arrow) or fail to convey their purpose (the NHS logo). This doesn't matter most of the time - but this morning the CSS was failing to load on one of the covid related services in production. The service still worked (Hooray for progressive enhancement!) but the NHS logo and the back arrow marred what was otherwise still quite a usable service.

We should investigate ways to make these (and any of the other components) more usable without CSS in case this happens again. Off the top of my head - putting some fallback colours natively into the NHS SVG, and giving it and the back button SVG some inherent dimensions would be a good start.

Examples

Design system homepage without CSS:

image


And one of the covid service whilst it had partial CSS

(For some reason it wasn't all missing, but the bug still rears it's head)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant