Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/class attributes #361

Merged
merged 13 commits into from
Jan 30, 2019
Merged

Feature/class attributes #361

merged 13 commits into from
Jan 30, 2019

Conversation

mcheung-nhs
Copy link
Collaborator

Description

Checklist

  • SCSS
  • Nunjucks macro
  • A standalone example
  • README/Documentation with HTML snippet
  • Tested against our testing policy (Resolution, Browser & Accessibility)
  • Print stylesheet considered
  • CHANGELOG entry

Removing any whitespace to tidy up resultant markup and refactor
nunjucks templates to make them more readable.

Templates amended:
- action link
- back link
- breadcrumb
- button
- care card
- contents list
- date input
- hint

More to come...
Added Nunjucks options for emergency alert and feedback banner
components.

Tidied up code for the other components.

Components amended:
- details
- do-dont-lists
- emergency alert
- error message
- error summary
- feedback banner
Added Nunjucks options for the hero and images components.

Code tidy of the Nunjucks templates and README updates.

Components amended:
- fieldset
- footer
- header
- hero
- hint
- images
Code tidy of the Nunjucks templates and README updates.

Components amended:
- input
- inset text
- label
- list panel
- nav a-z
- pagination
- panel
Tidied up code in Nunjucks templates and READMEs.
For the radio component, removed the conditional parameter as this has
not yet been implemented.

Components amended:
- error-message
- promo
- radios
- review-review
- select
- skip-link
- tables
- textarea
- warning-callout
Removing any whitespace to tidy up resultant markup and refactor
nunjucks templates to make them more readable.

Templates amended:
- action link
- back link
- breadcrumb
- button
- care card
- contents list
- date input
- hint

More to come...
Added Nunjucks options for emergency alert and feedback banner
components.

Tidied up code for the other components.

Components amended:
- details
- do-dont-lists
- emergency alert
- error message
- error summary
- feedback banner
Added Nunjucks options for the hero and images components.

Code tidy of the Nunjucks templates and README updates.

Components amended:
- fieldset
- footer
- header
- hero
- hint
- images
Code tidy of the Nunjucks templates and README updates.

Components amended:
- input
- inset text
- label
- list panel
- nav a-z
- pagination
- panel
Tidied up code in Nunjucks templates and READMEs.
For the radio component, removed the conditional parameter as this has
not yet been implemented.

Components amended:
- error-message
- promo
- radios
- review-review
- select
- skip-link
- tables
- textarea
- warning-callout
Copy link
Member

@chrimesdev chrimesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just fixing the BackstopJS tests for the Footer change.

@chrimesdev chrimesdev merged commit 3774274 into master Jan 30, 2019
@chrimesdev chrimesdev deleted the feature/class-attributes branch January 30, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants