-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/class attributes #361
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing any whitespace to tidy up resultant markup and refactor nunjucks templates to make them more readable. Templates amended: - action link - back link - breadcrumb - button - care card - contents list - date input - hint More to come...
Added Nunjucks options for emergency alert and feedback banner components. Tidied up code for the other components. Components amended: - details - do-dont-lists - emergency alert - error message - error summary - feedback banner
Added Nunjucks options for the hero and images components. Code tidy of the Nunjucks templates and README updates. Components amended: - fieldset - footer - header - hero - hint - images
Code tidy of the Nunjucks templates and README updates. Components amended: - input - inset text - label - list panel - nav a-z - pagination - panel
Tidied up code in Nunjucks templates and READMEs. For the radio component, removed the conditional parameter as this has not yet been implemented. Components amended: - error-message - promo - radios - review-review - select - skip-link - tables - textarea - warning-callout
Removing any whitespace to tidy up resultant markup and refactor nunjucks templates to make them more readable. Templates amended: - action link - back link - breadcrumb - button - care card - contents list - date input - hint More to come...
Added Nunjucks options for emergency alert and feedback banner components. Tidied up code for the other components. Components amended: - details - do-dont-lists - emergency alert - error message - error summary - feedback banner
Added Nunjucks options for the hero and images components. Code tidy of the Nunjucks templates and README updates. Components amended: - fieldset - footer - header - hero - hint - images
Code tidy of the Nunjucks templates and README updates. Components amended: - input - inset text - label - list panel - nav a-z - pagination - panel
Tidied up code in Nunjucks templates and READMEs. For the radio component, removed the conditional parameter as this has not yet been implemented. Components amended: - error-message - promo - radios - review-review - select - skip-link - tables - textarea - warning-callout
…ntend into feature/class-attributes
chrimesdev
approved these changes
Jan 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just fixing the BackstopJS tests for the Footer change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist