Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check all nunjucks components to allow class and attributes parameters #318

Closed
mcheung-nhs opened this issue Dec 21, 2018 · 0 comments
Closed

Check all nunjucks components to allow class and attributes parameters #318

mcheung-nhs opened this issue Dec 21, 2018 · 0 comments
Assignees
@mcheung-nhs

Comments

@mcheung-nhs
Copy link
Collaborator

mcheung-nhs commented Dec 21, 2018 •
edited
Loading

All components should have the option to add an extra class and/or attribute parameter to either the relevant HTML element, such as an anchor tag, or to the containing <div> so it or any child element can be targeted.
@mcheung-nhs mcheung-nhs self-assigned this Jan 17, 2019
mcheung-nhs added a commit that referenced this issue Jan 24, 2019
@mcheung-nhs
[refs #318] Tidy up of code and outputted markup of components
58bef47 
Removing any whitespace to tidy up resultant markup and refactor
nunjucks templates to make them more readable.

Templates amended:
- action link
- back link
- breadcrumb
- button
- care card
- contents list
- date input
- hint

More to come...
mcheung-nhs added a commit that referenced this issue Jan 24, 2019
@mcheung-nhs
[refs #318] Update Nunjucks templates and READMEs
75479f9 
Added Nunjucks options for emergency alert and feedback banner
components.

Tidied up code for the other components.

Components amended:
- details
- do-dont-lists
- emergency alert
- error message
- error summary
- feedback banner
mcheung-nhs added a commit that referenced this issue Jan 24, 2019
@mcheung-nhs
[refs #318] Updates to the Nunjucks templates and READMEs
4f4b6de 
Added Nunjucks options for the hero and images components.

Code tidy of the Nunjucks templates and README updates.

Components amended:
- fieldset
- footer
- header
- hero
- hint
- images
mcheung-nhs added a commit that referenced this issue Jan 25, 2019
@mcheung-nhs
[refs #318] Update Nunjucks templates and READMEs
155cf32 
Code tidy of the Nunjucks templates and README updates.

Components amended:
- input
- inset text
- label
- list panel
- nav a-z
- pagination
- panel
mcheung-nhs added a commit that referenced this issue Jan 25, 2019
@mcheung-nhs
[refs #318] Update remaining component Nunjucks templates and READMEs
de50934 
Tidied up code in Nunjucks templates and READMEs.
For the radio component, removed the conditional parameter as this has
not yet been implemented.

Components amended:
- error-message
- promo
- radios
- review-review
- select
- skip-link
- tables
- textarea
- warning-callout
mcheung-nhs added a commit that referenced this issue Jan 25, 2019
@mcheung-nhs
[refs #318] Tidy up of code and outputted markup of components
8a40a7d 
Removing any whitespace to tidy up resultant markup and refactor
nunjucks templates to make them more readable.

Templates amended:
- action link
- back link
- breadcrumb
- button
- care card
- contents list
- date input
- hint

More to come...
mcheung-nhs added a commit that referenced this issue Jan 25, 2019
@mcheung-nhs
[refs #318] Update Nunjucks templates and READMEs
c523ea5 
Added Nunjucks options for emergency alert and feedback banner
components.

Tidied up code for the other components.

Components amended:
- details
- do-dont-lists
- emergency alert
- error message
- error summary
- feedback banner
mcheung-nhs added a commit that referenced this issue Jan 25, 2019
@mcheung-nhs
[refs #318] Updates to the Nunjucks templates and READMEs
8da3e61 
Added Nunjucks options for the hero and images components.

Code tidy of the Nunjucks templates and README updates.

Components amended:
- fieldset
- footer
- header
- hero
- hint
- images
mcheung-nhs added a commit that referenced this issue Jan 25, 2019
@mcheung-nhs
[refs #318] Update Nunjucks templates and READMEs
5550791 
Code tidy of the Nunjucks templates and README updates.

Components amended:
- input
- inset text
- label
- list panel
- nav a-z
- pagination
- panel
mcheung-nhs added a commit that referenced this issue Jan 25, 2019
@mcheung-nhs
[refs #318] Update remaining component Nunjucks templates and READMEs
9d711fe 
Tidied up code in Nunjucks templates and READMEs.
For the radio component, removed the conditional parameter as this has
not yet been implemented.

Components amended:
- error-message
- promo
- radios
- review-review
- select
- skip-link
- tables
- textarea
- warning-callout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcheung-nhs mcheung-nhs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcheung-nhs @chrimesdev